-
Notifications
You must be signed in to change notification settings - Fork 262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dead code #4314
base: main
Are you sure you want to change the base?
Remove dead code #4314
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -438,8 +438,7 @@ | |
PlatformServiceProvider.Instance.AdapterTraceLogger.LogInfo("Executing test {0}", unitTestElement.TestMethod.Name); | ||
|
||
// Run single test passing test context properties to it. | ||
IDictionary<TestProperty, object?> tcmProperties = TcmTestPropertiesProvider.GetTcmProperties(currentTest); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This dictionary was always empty because we don't set |
||
Dictionary<string, object?> testContextProperties = GetTestContextProperties(tcmProperties, sourceLevelParameters); | ||
Dictionary<string, object?> testContextProperties = GetTestContextProperties(sourceLevelParameters); | ||
UnitTestResult[] unitTestResult = testRunner.RunSingleTest(unitTestElement.TestMethod, testContextProperties); | ||
|
||
PlatformServiceProvider.Instance.AdapterTraceLogger.LogInfo("Executed test {0}", unitTestElement.TestMethod.Name); | ||
|
@@ -479,21 +478,14 @@ | |
/// <summary> | ||
/// Get test context properties. | ||
/// </summary> | ||
/// <param name="tcmProperties">Tcm properties.</param> | ||
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfxsrc/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfxsrc/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
Check failure on line 481 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfxsrc/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L481
|
||
/// <param name="sourceLevelParameters">Source level parameters.</param> | ||
Check failure on line 482 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L482
Check failure on line 482 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build MacOS Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L482
Check failure on line 482 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Debug)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L482
Check failure on line 482 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfx (Build Linux Release)src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L482
Check failure on line 482 in src/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs Azure Pipelines / microsoft.testfxsrc/Adapter/MSTest.TestAdapter/Execution/TestExecutionManager.cs#L482
|
||
/// <returns>Test context properties.</returns> | ||
private static Dictionary<string, object?> GetTestContextProperties( | ||
IDictionary<TestProperty, object?> tcmProperties, | ||
IDictionary<string, object> sourceLevelParameters) | ||
{ | ||
var testContextProperties = new Dictionary<string, object?>(); | ||
|
||
// Add tcm properties. | ||
foreach (KeyValuePair<TestProperty, object?> propertyPair in tcmProperties) | ||
{ | ||
testContextProperties[propertyPair.Key.Id] = propertyPair.Value; | ||
} | ||
|
||
// Add source level parameters. | ||
foreach (KeyValuePair<string, object> propertyPair in sourceLevelParameters) | ||
{ | ||
|
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We never set a value for any of these properties. @Evangelink Could they be magically set by something else (not us)? Or is it really dead code?