Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #4258

Open
wants to merge 22 commits into
base: main
Choose a base branch
from
Open

[main] Update dependencies from dotnet/arcade #4258

wants to merge 22 commits into from
+19 −15

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 6, 2024 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 860c99cc-ff50-47cb-c150-08d91ef85541
  • Build: 20241206.6
  • Date Produced: December 6, 2024 10:46:21 PM UTC
  • Commit: 61b8f746424762d2e3173ebfaab19346224d591c
  • Branch: refs/heads/main

From https://github.com/microsoft/testanywhere

  • Subscription: e51b9d00-c153-4eff-54a8-08dbd5a5c4be
  • Build: 20241217.4
  • Date Produced: December 17, 2024 3:03:01 PM UTC
  • Commit: 2da1eef10ff2c9666af1f9ae10bb6cd3bee8764b
  • Branch: refs/heads/main

From https://dev.azure.com/devdiv/DevDiv/_git/vs-code-coverage

  • Subscription: 80f35d75-3aef-4935-4458-08dc8b6ac1be
  • Build: 20241216.1
  • Date Produced: December 16, 2024 11:06:17 AM UTC
  • Commit: 6e803749272c23d6a644c780f31d4f9e2eedd22d
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
91fe3df 
…205.6

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.XliffTasks
 From Version 10.0.0-beta.24604.4 -> To Version 10.0.0-beta.24605.6
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
26d1ed9 
…ild 20241205.2

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24604.2 -> To Version 1.5.0-preview.24605.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade [main] Update dependencies from dotnet/arcade, microsoft/testanywhere Dec 6, 2024
@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20241…
cf6ceb9 
…206.6

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.XliffTasks
 From Version 10.0.0-beta.24604.4 -> To Version 10.0.0-beta.24606.6
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
838315b 
…ild 20241206.1

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24604.2 -> To Version 1.5.0-preview.24606.1
@dotnet-maestro
Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-…
962de1a 
…code-coverage build 20241206.2

Microsoft.Testing.Extensions.CodeCoverage
 From Version 17.13.2-preview.24605.2 -> To Version 17.13.2-preview.24606.2
@dotnet-maestro dotnet-maestro bot changed the title [main] Update dependencies from dotnet/arcade, microsoft/testanywhere [main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotnet/arcade, microsoft/testanywhere Dec 7, 2024
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
3b8e4bf 
…ild 20241207.2

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24604.2 -> To Version 1.5.0-preview.24607.2
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
cb61ba6 
…ild 20241208.1

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24604.2 -> To Version 1.5.0-preview.24608.1
@Evangelink Evangelink mentioned this pull request Dec 11, 2024
Merged
dotnet-maestro bot and others added 3 commits December 11, 2024 13:37
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
33cb066 
…ild 20241211.2

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24608.1 -> To Version 1.5.0-preview.24611.2
@Evangelink
Merge branch 'main' into darc-main-c77118b8-778c-4f4c-94f2-e89027a72b6e
88f62e8 
# Conflicts:
#	eng/Version.Details.xml
#	eng/Versions.props
@Evangelink
Use dotnet10 feed
4de3b39
Evangelink
Evangelink previously approved these changes Dec 11, 2024
View reviewed changes
@Evangelink Evangelink enabled auto-merge (squash) December 11, 2024 15:53
fhnaseer
fhnaseer previously approved these changes Dec 12, 2024
View reviewed changes
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
47daaa5 
…ild 20241211.3

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24608.1 -> To Version 1.5.0-preview.24611.3
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
9a65528 
…ild 20241213.1

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24608.1 -> To Version 1.5.0-preview.24613.1
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
2ac14d1 
…ild 20241214.1

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24608.1 -> To Version 1.5.0-preview.24614.1
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
a032349 
…ild 20241216.3

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24608.1 -> To Version 1.6.0-preview.24616.3
@dotnet-maestro
Update dependencies from https://dev.azure.com/devdiv/DevDiv/_git/vs-…
092dfa5 
…code-coverage build 20241216.1

Microsoft.Testing.Extensions.CodeCoverage
 From Version 17.13.2-preview.24606.2 -> To Version 17.14.0-preview.24616.1
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
9919a3f 
…ild 20241216.4

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24608.1 -> To Version 1.6.0-preview.24616.4
@dotnet-maestro
Update dependencies from https://github.com/microsoft/testanywhere bu…
998a30b 
…ild 20241217.4

Microsoft.Testing.Extensions.Retry
 From Version 1.5.0-preview.24608.1 -> To Version 1.6.0-preview.24617.4
@dkurepa dkurepa mentioned this pull request Dec 18, 2024
Open
@Evangelink Evangelink changed the title [main] Update dependencies from devdiv/DevDiv/vs-code-coverage, dotnet/arcade, microsoft/testanywhere [main] Update dependencies from dotnet/arcade Dec 24, 2024
@Evangelink
Copy link
Member

We need to investigate the System.Runtime.CompilerServices.Unsafe issue. We have it locally for quite some time but CI was good, with this PR issue is starting to appear on CI too. cc @Youssef1313

@Youssef1313
Copy link
Member

Youssef1313 commented Dec 29, 2024 •
edited
Loading

@Evangelink It looks like the last build in this PR doesn't have the System.Runtime.CompilerServices.Unsafe issue? Not sure what have changed to let that failure go away. I haven't re-tested locally again yet.

There is now failure that happens only in SB though

CSC(0,0): error AD0001: (NETCORE_ENGINEERING_TELEMETRY=Build) Analyzer 'Microsoft.Interop.Analyzers.AddGeneratedComClassAnalyzer' threw an exception of type 'System.Resources.MissingManifestResourceException' with message 'Could not find the resource "FxResources.Microsoft.Interop.ComInterfaceGenerator.SR.resources" among the resources "" embedded in the assembly "Microsoft.Interop.ComInterfaceGenerator", nor among the resources in any satellite assemblies for the specified culture. Perhaps the resources were embedded with an incorrect name.'.

But that doesn't seem to be something on our side? dotnet/source-build#4810

@Youssef1313 Youssef1313 mentioned this pull request Dec 29, 2024
Open
Youssef1313
Youssef1313 reviewed Dec 29, 2024
View reviewed changes
global.json
@@ -1,6 +1,6 @@
{
"tools": {
"dotnet": "9.0.100",
"dotnet": "10.0.100-alpha.1.24573.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Evangelink Do we want to move that fast to 10.x?
I'd also assume that downgrading back to 9.0.100 will be green and avoid the current SB issue until it's investigated further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@Evangelink Evangelink Evangelink approved these changes

@fhnaseer fhnaseer fhnaseer left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Evangelink @Youssef1313 @fhnaseer