.Net: adds support for strict mode with OpenAI #9924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
…pping Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
markwallace-microsoft
added
.NET
github-actions
bot
changed the title
1 task
Signed-off-by: Vincent Biret <[email protected]>
markwallace-microsoft
approved these changes
Dec 13, 2024
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
… generation Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
…-kernel into feat/strict-mode
Signed-off-by: Vincent Biret <[email protected]>
| serverUrlOverride: new Uri("https://graph.microsoft.com/v1.0")); | ||
| serverUrlOverride: new Uri("https://graph.microsoft.com/v1.0"), | ||
| enableDynamicOperationPayload: false, | ||
| enablePayloadNamespacing: true); |
There was a problem hiding this comment.
Namespacing is only used when dynamic payload construction is enabled. So, enabling it won't make a difference since payload construction is disabled. Same in a few other samples.
| @@ -178,7 +178,7 @@ public static async IAsyncEnumerable<ChatMessageContent> GetMessagesAsync(Assist | |||
|
|
|||
| FunctionCallsProcessor functionProcessor = new(logger); | |||
| // This matches current behavior. Will be configurable upon integrating with `FunctionChoice` (#6795/#5200) | |||
| FunctionChoiceBehaviorOptions functionOptions = new() { AllowConcurrentInvocation = true, AllowParallelCalls = true }; | |||
| FunctionChoiceBehaviorOptions functionOptions = new() { AllowConcurrentInvocation = true, AllowParallelCalls = true, AllowStrictSchemaAdherence = true }; | |||
There was a problem hiding this comment.
Shouldn't we have the strict mode configurable? To keep it off by default and allow it to be enabled if necessary. This way, we can avoid unnecessary behavioral changes.
| @@ -33,7 +33,7 @@ public string? ArgumentName | |||
| /// <summary> | |||
| /// The parameter type - string, integer, number, boolean, array and object. | |||
| /// </summary> | |||
| internal string Type { get; } | |||
| public string Type { get; } | |||
There was a problem hiding this comment.
The type and array item type parameters together with constructor were intentionally kept internal because their types will change during the migration to Microsoft.OpenApi V2. Consider adding a freezable setter to the Schema property, like the one for the ArgumentName property, so that a modified schema can be assigned.
| { | ||
| CreatePayloadArtificialParameter(operation), | ||
| CreateContentTypeArtificialParameter(operation) | ||
| }.Select(p => parameterFilter(new(operation, p))).OfType<RestApiParameter>().ToList(); |
There was a problem hiding this comment.
Suggested change
| }.Select(p => parameterFilter(new(operation, p))).OfType<RestApiParameter>().ToList(); | |
| }.Where(p => parameterFilter(new(operation, p)) is not null).ToList(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9786
closes #9741