-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ct-metrics): BPF implementation #1102
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 10 changed files in this pull request and generated no suggestions.
Files not reviewed (2)
- pkg/plugin/conntrack/_cprog/conntrack.c: Language not supported
- pkg/plugin/packetparser/_cprog/packetparser.c: Language not supported
bdbcd8f
to
1031c3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 8 out of 17 changed files in this pull request and generated no suggestions.
Files not reviewed (9)
- pkg/plugin/conntrack/_cprog/conntrack.c: Language not supported
- pkg/plugin/conntrack/_cprog/dynamic.h: Language not supported
- pkg/plugin/packetparser/_cprog/dynamic.h: Language not supported
- pkg/plugin/packetparser/_cprog/packetparser.c: Language not supported
- pkg/plugin/packetparser/packetparser_bpfel_x86.go: Evaluated as low risk
- pkg/plugin/packetparser/packetparser_linux.go: Evaluated as low risk
- pkg/config/config.go: Evaluated as low risk
- deploy/legacy/manifests/controller/helm/retina/templates/configmap.yaml: Evaluated as low risk
- deploy/hubble/manifests/controller/helm/retina/templates/agent/configmap.yaml: Evaluated as low risk
Overall looks good to me, punting to @nddq to review the conntrack pieces. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 19 changed files in this pull request and generated no suggestions.
Files not reviewed (12)
- pkg/plugin/conntrack/_cprog/conntrack.c: Language not supported
- pkg/plugin/conntrack/_cprog/dynamic.h: Language not supported
- pkg/plugin/packetparser/_cprog/dynamic.h: Language not supported
- pkg/plugin/packetparser/_cprog/packetparser.c: Language not supported
- pkg/plugin/packetparser/packetparser_bpfel_arm64.go: Evaluated as low risk
- pkg/plugin/packetparser/packetparser_linux.go: Evaluated as low risk
- pkg/plugin/packetparser/packetparser_bpfel_x86.go: Evaluated as low risk
- pkg/config/config.go: Evaluated as low risk
- deploy/hubble/manifests/controller/helm/retina/templates/agent/configmap.yaml: Evaluated as low risk
- pkg/plugin/conntrack/conntrack_bpfel_x86.go: Evaluated as low risk
- deploy/legacy/manifests/controller/helm/retina/templates/configmap.yaml: Evaluated as low risk
- pkg/plugin/conntrack/conntrack_bpfel_arm64.go: Evaluated as low risk
f2fd1a1
to
14f219c
Compare
bd62591
to
9eec75c
Compare
Description
BPF implementation for connection tracking metrics. This is the data-plane work mentioned in this comment #1057 (comment)
Summary
Related Issue
#806
Checklist
git commit -S -s ...
). See this documentation on signing commits.Screenshots (if applicable) or Testing Completed
Please add any relevant screenshots or GIFs to showcase the changes made.
enableConntrackMetrics=false
enableConntrackMetrics=true
At userland level I provisionally added a debug statement, just for this test, in
packetparser_linux.go
(without IP and proto translation)Additional Notes
Add any additional notes or context about the pull request here.
Please refer to the CONTRIBUTING.md file for more information on how to contribute to this project.