Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of Using Namespace std; #293

Merged
merged 7 commits into from
Jan 2, 2025
Merged

Conversation

Astabol
Copy link
Contributor

@Astabol Astabol commented Dec 28, 2024

Hello,

  1. Migrated from printf to std::cout.
  2. Introduced header iostream and iomanip
  3. Removal of using Namespace std

Tested from myside and its working!
Thanks

@nibanks
Copy link
Member

nibanks commented Dec 30, 2024

What is the motivation for this change? My personal preference currently is to stay with printf unless there's a good reason to move.

src/quicreach.cpp Fixed Show fixed Hide fixed
src/quicreach.cpp Fixed Show fixed Hide fixed
src/quicreach.cpp Fixed Show fixed Hide fixed
src/quicreach.cpp Fixed Show fixed Hide fixed
src/quicreach.cpp Fixed Show fixed Hide fixed
src/quicreach.cpp Fixed Show fixed Hide fixed
src/quicreach.cpp Fixed Show fixed Hide fixed
src/quicreach.cpp Fixed Show fixed Hide fixed
src/quicreach.cpp Fixed Show fixed Hide fixed
@Astabol
Copy link
Contributor Author

Astabol commented Dec 30, 2024

What is the motivation for this change? My personal preference currently is to stay with printf unless there's a good reason to move.

Instead of having C++ project I saw most of the component is used here is from C. So, I am working on the migration of this project completely to C++

That is the reason I thought of doing the migration step by step. And I choose printf first.

Using Namespace std removed; & Currently working on migrating of one of the function.

Most Importly std::cout is having type safety. So, I think its convanient to use it over printf.

Thank You

@Astabol Astabol changed the title Migrated from printf to std::cout Migrated from printf to std::cout && Removal of Using Namespace std; Dec 30, 2024
src/quicreach.cpp Outdated Show resolved Hide resolved
@Astabol Astabol closed this Dec 30, 2024
@Astabol Astabol reopened this Dec 30, 2024
@Astabol
Copy link
Contributor Author

Astabol commented Dec 30, 2024

I don't know how the pull request got closed. I was trying "new merge experience".

Anyway I reopened it.

src/quicreach.cpp Outdated Show resolved Hide resolved
@nibanks
Copy link
Member

nibanks commented Dec 31, 2024

I appreciate the contribution. Thank you! For this particular change, though, I feel it makes the code harder to read. I am reaching out on our Discord server (for MsQuic) to get more community feedback before I make any final decision.

@Astabol
Copy link
Contributor Author

Astabol commented Dec 31, 2024 via email

@Astabol Astabol changed the title Migrated from printf to std::cout && Removal of Using Namespace std; Removal of Using Namespace std; Jan 2, 2025
@Astabol
Copy link
Contributor Author

Astabol commented Jan 2, 2025

Hello @nibanks, I reverted the migration. Kindly review it. Thank You

@nibanks nibanks merged commit 40f1db4 into microsoft:main Jan 2, 2025
24 checks passed
nibanks pushed a commit that referenced this pull request Jan 2, 2025
@nibanks
Copy link
Member

nibanks commented Jan 2, 2025

Thanks so much for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants