docs(java): Add SoftAssertions for Java #26512
Conversation
| } | ||
| ``` | ||
|
|
||
| ## method: SoftAssertions.create |
There was a problem hiding this comment.
FYI, you'll need to update ApiGenerator when rolling this change to have all static methods generated in the API.
| * since: v1.38 | ||
| * langs: java | ||
|
|
||
| Runs all the assertions have been executed for this [SoftAssertions] object. If any assertions fail, this method throws an AssertionFailedError with the details of all the failed assertions. |
There was a problem hiding this comment.
| Runs all the assertions have been executed for this [SoftAssertions] object. If any assertions fail, this method throws an AssertionFailedError with the details of all the failed assertions. | |
| Runs after all the assertions have been executed for this [SoftAssertions] object. If any assertions failed, this method throws an AssertionFailedError with the details of all the failed assertions. |
| SoftAssertions softly = SoftAssertions.create(); | ||
| ``` | ||
|
|
||
| ## method: SoftAssertions.expectLocator |
There was a problem hiding this comment.
I'm fine with adding expectLocator and expectAPIResponse right away, but we'll have to stub them as unimplemented for now during the roll. Alternatively, you could add them later to the docs, up to you.
There was a problem hiding this comment.
I have the implementation of these already worked out but i haven't committed it yet. If it's okay with you, i think we can do everything together.
|
Once this lands, let's roll new driver with the new API as a separate PR keeping all new methods unimplemented and then apply your implementation on top of it in a separate PR. |
|
I'll commit this right-away to unblock you. Feel free to address any comments in a follow-up PR. |
|
FYI, this run should include your change in the driver. |
This reverts commit 475c96d.
As explained in microsoft/playwright-java#819 (comment) we are not ready to ship this in its current form. Reverting for now. This reverts commit 475c96d.
This PR adds the `SoftAssertions` API for Java. Related PR: microsoft/playwright-java#1340 Note: microsoft/playwright.dev#1135 needs to be merged in order for the markdown in this PR to be rendered without errors
…icrosoft#26917) As explained in microsoft/playwright-java#819 (comment) we are not ready to ship this in its current form. Reverting for now. This reverts commit 475c96d.
This PR adds the
SoftAssertionsAPI for Java. Related PR: microsoft/playwright-java#1340Note: microsoft/playwright.dev#1135 needs to be merged in order for the markdown in this PR to be rendered without errors
cc: @yury-s