feat: support device name in playwright fixtures #1472
Conversation
|
cc @uchagani |
Reference microsoft#1369 Reference microsoft#939
| @@ -83,6 +84,15 @@ public Options setBrowserName(String browserName) { | |||
| return this; | |||
| } | |||
|
|
|||
| public String getDeviceName() { | |||
There was a problem hiding this comment.
It's unfortunate that we cannot read back the actual values here, only the device name. However, that's better than nothing.
| public String defaultBrowserType; | ||
|
|
||
| static DeviceDescriptor findByName(Playwright playwright, String name) { | ||
| JsonArray devices = ((PlaywrightImpl) playwright).deviceDescriptors(); |
There was a problem hiding this comment.
@yury-s this is returning null for me and so a null pointer exception is being thrown.
There was a problem hiding this comment.
Hmm, that's odd. Is options in options.deviceName null or where does it come from?
There was a problem hiding this comment.
I believe PlaywrightImpl.deviceDescriptors() is returning null so the for loop throws a null pointer exception:
There was a problem hiding this comment.
Hmm, do you have a test where this is happening? This should never happen if playwright is initialized.
There was a problem hiding this comment.
Ok, I assume it is just the new test. It passes on the bots and locally. Could it be that you have some stale driver? We changed the way device descriptors pushed to the client some time ago. Try downloading current driver and see if it still fails.
There was a problem hiding this comment.
Just running ./scripts/download_driver_for_all_platforms.sh -f and rebuilding should be sufficient
There was a problem hiding this comment.
it was failing on main for me too but you figured it out. downloaded the current driver and it's all good. apologies for that. i'll make running that command part of my workflow.
Reference #1369
Reference #939