fifo should be correct now as well.

microsoft · Oct 6, 2023 · d985516 · d985516
1 parent 939c97a
commit d985516
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/src/fifo.cc b/src/fifo.cc
@@ -49,7 +49,9 @@ MSCCLPP_API_CPP ProxyTrigger Fifo::poll() {
 }
 
 MSCCLPP_API_CPP void Fifo::pop() {
-  *(volatile uint64_t*)(&pimpl->triggers.get()[pimpl->hostTail % pimpl->size]) = 0;
+  cuda::atomic_ref<uint64_t, cuda::thread_scope_system>{pimpl->triggers.get()[pimpl->hostTail % pimpl->size].fst}.store(
+      0, cuda::memory_order_release);
+
   (pimpl->hostTail)++;
 }
 

diff --git a/src/semaphore.cc b/src/semaphore.cc
@@ -1,6 +1,7 @@
 // Copyright (c) Microsoft Corporation.
 // Licensed under the MIT license.
 
+#include <cuda/atomic>
 #include <mscclpp/semaphore.hpp>
 
 #include "api.h"