Initial heap local deferred free implementation #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Apr 29, 2021
jserv
reviewed
Apr 29, 2021
jserv
reviewed
Apr 29, 2021
jserv
reviewed
Jun 27, 2021
| /// @param arg Argument that was passed at registration to hold extra state. | ||
| /// | ||
| /// @see mi_heap_register_deferred_free | ||
| typedef void (mi_local_deferred_free_fun)(mi_heap_t* heap,bool force,unsigned long long heartbeat,void* arg); |
There was a problem hiding this comment.
For consistent style, a space character should follow the comma. That is,
typedef void (mi_local_deferred_free_fun)(mi_heap_t* heap, bool force, unsigned long long heartbeat, void* arg);
jserv
reviewed
Jun 27, 2021
| /// to be called deterministically after some number of allocations | ||
| /// (regardless of freeing or available free memory). | ||
| /// At most one \a deferred_free function can be active. | ||
| void mi_heap_register_deferred_free(mi_heap_t* heap,mi_local_deferred_free_fun* deferred_free, void* arg); |
There was a problem hiding this comment.
Ditto. Take care of the style.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@daanx I actually managed to implement heap local deferred free function in a few minutes. But I don't know if my code that invokes
heap->deferred_freefunction in_mi_deferred_freeis correct.