Windows support for Service tool added. #3573
Open
+97
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SRIKKANTH
force-pushed
the
smyakam/service_tool_29_12_20024
branch
5 times, most recently
from
5678bbc to
2f38007
Compare
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
lisa/base_tools/service.py
Outdated
| output_json=True, | ||
| fail_on_error=False, | ||
| ) | ||
| if not service_status: |
There was a problem hiding this comment.
Use above fail_on_error, instead of custom error.
There was a problem hiding this comment.
it looks not fixed. Set above fail_on_error=True, let the above line failed. If the error message is not clear, catch it and add more information.
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
squirrelsc
reviewed
Dec 30, 2024
SRIKKANTH
force-pushed
the
smyakam/service_tool_29_12_20024
branch
from
9cfc7ab to
727572d
Compare
SRIKKANTH
force-pushed
the
smyakam/service_tool_29_12_20024
branch
from
5b555e0 to
72582c5
Compare
This pull request adds Windows support for the Service tool.
SRIKKANTH
force-pushed
the
smyakam/service_tool_29_12_20024
branch
from
72582c5 to
30a8249
Compare
squirrelsc
reviewed
Jan 2, 2025
|
|
||
| if timeout < timer.elapsed(): | ||
| raise LisaException( | ||
| f"service '{name}' still in '{current_service_status}' state after '{timeout}' seconds" # noqa: E501 |
There was a problem hiding this comment.
Change it to multiple lines, not to overuse E501.
f"service '{name}' still in '{current_service_status}' state "
f"after '{timeout}' seconds"
squirrelsc
reviewed
Jan 2, 2025
| return WindowsServiceStatus(int(service_status["Status"])) | ||
|
|
||
| def _is_service_inactive(self, name: str) -> bool: | ||
| return self._get_status(name) == WindowsServiceStatus.STOPPED |
There was a problem hiding this comment.
Should it use the same result as _check_service_running? If the service is in other statuses, what's expected?
squirrelsc
reviewed
Jan 2, 2025
| self._get_status(name) | ||
| return True | ||
| except LisaException: | ||
| return False |
There was a problem hiding this comment.
- When checking the service exist or not, use more accurate checking, like parse output, instead of getting status, and judge non-exists on any exception.
- Not overuse try/except on normal status.
squirrelsc
reviewed
Jan 2, 2025
| ) | ||
| self.wait_for_service_stop(name) | ||
|
|
||
| def wait_for_service_start(self, name: str) -> None: |
There was a problem hiding this comment.
If the method is not used outside of the class, remove them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds Windows support for the Service tool.