Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Badge component default settings #3832

Merged

Conversation

rurikoaraki
Copy link
Collaborator

Platforms Impacted

  • iOS
  • macOS
  • win32 (Office)
  • windows
  • android

Description of changes

Fixing Badge component's default settings to align with SPEC:

  • Appearance should default to filled, which is currently not applying as it's missing from the lookup function. Due to this, badgeColor prop did not work properly.
  • Size is currently defaulting to large, not medium as claimed by SPEC. Fixing to default to medium
  • Also explicitly applying brand badgeColor default, though this seems to already be working.

Verification

Before After
image image

Pull request checklist

This PR has considered (when applicable):

  • Automated Tests
  • Documentation and examples
  • Keyboard Accessibility
  • Voiceover
  • Internationalization and Right-to-left Layouts

@rurikoaraki rurikoaraki requested a review from a team as a code owner January 8, 2025 22:56
@rurikoaraki rurikoaraki merged commit f4469e4 into microsoft:main Jan 9, 2025
11 checks passed
@rurikoaraki rurikoaraki deleted the user/ruaraki/badge_filled_default branch January 9, 2025 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants