Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ListComponentBase] Fix #3029 invoke ValueChanged when initially selecting an option #3105

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

pk9r
Copy link
Contributor

@pk9r pk9r commented Dec 27, 2024

Pull Request

πŸ“– Description

Fix 3029, Combobox no longer causes the page to become unresponsive.
Image

#3029 (comment)

🎫 Issues

#3029

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Component-specific

  • I have added a new component
  • I have added Unit Tests for my new component
  • I have modified an existing component
  • I have validated the Unit Tests for an existing component

⏭ Next Steps

The displayed value of the combobox is not consistent with its value. I have no idea how to solve this.
peek_2

@pk9r pk9r requested a review from dvoituron December 27, 2024 11:58
@vnbaaij vnbaaij merged commit 75b8f5f into microsoft:dev Dec 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants