-
Notifications
You must be signed in to change notification settings - Fork 564
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
7 changed files
with
108 additions
and
1,514 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,91 @@ | ||
diff --git a/lib/nghttp2/lib/includes/nghttp2/nghttp2.h b/lib/nghttp2/lib/includes/nghttp2/nghttp2.h | ||
index 66ea3c63c..5378daf43 100644 | ||
--- a/lib/nghttp2/lib/includes/nghttp2/nghttp2.h | ||
+++ b/lib/nghttp2/lib/includes/nghttp2/nghttp2.h | ||
@@ -440,7 +440,12 @@ typedef enum { | ||
* exhaustion on server side to send these frames forever and does | ||
* not read network. | ||
*/ | ||
- NGHTTP2_ERR_FLOODED = -904 | ||
+ NGHTTP2_ERR_FLOODED = -904, | ||
+ /** | ||
+ * When a local endpoint receives too many CONTINUATION frames | ||
+ * following a HEADER frame. | ||
+ */ | ||
+ NGHTTP2_ERR_TOO_MANY_CONTINUATIONS = -905, | ||
} nghttp2_error; | ||
|
||
/** | ||
diff --git a/lib/nghttp2/lib/nghttp2_helper.c b/lib/nghttp2/lib/nghttp2_helper.c | ||
index 93dd4754b..b3563d98e 100644 | ||
--- a/lib/nghttp2/lib/nghttp2_helper.c | ||
+++ b/lib/nghttp2/lib/nghttp2_helper.c | ||
@@ -336,6 +336,8 @@ const char *nghttp2_strerror(int error_code) { | ||
"closed"; | ||
case NGHTTP2_ERR_TOO_MANY_SETTINGS: | ||
return "SETTINGS frame contained more than the maximum allowed entries"; | ||
+ case NGHTTP2_ERR_TOO_MANY_CONTINUATIONS: | ||
+ return "Too many CONTINUATION frames following a HEADER frame"; | ||
default: | ||
return "Unknown error code"; | ||
} | ||
diff --git a/lib/nghttp2/lib/nghttp2_session.c b/lib/nghttp2/lib/nghttp2_session.c | ||
index c0d86026a..51ed4494e 100644 | ||
--- a/lib/nghttp2/lib/nghttp2_session.c | ||
+++ b/lib/nghttp2/lib/nghttp2_session.c | ||
@@ -496,6 +496,7 @@ static int session_new(nghttp2_session **session_ptr, | ||
(*session_ptr)->max_send_header_block_length = NGHTTP2_MAX_HEADERSLEN; | ||
(*session_ptr)->max_outbound_ack = NGHTTP2_DEFAULT_MAX_OBQ_FLOOD_ITEM; | ||
(*session_ptr)->max_settings = NGHTTP2_DEFAULT_MAX_SETTINGS; | ||
+ (*session_ptr)->max_continuations = NGHTTP2_DEFAULT_MAX_CONTINUATIONS; | ||
|
||
if (option) { | ||
if ((option->opt_set_mask & NGHTTP2_OPT_NO_AUTO_WINDOW_UPDATE) && | ||
@@ -6778,6 +6779,8 @@ ssize_t nghttp2_session_mem_recv(nghttp2_session *session, const uint8_t *in, | ||
} | ||
} | ||
session_inbound_frame_reset(session); | ||
+ | ||
+ session->num_continuations = 0; | ||
} | ||
break; | ||
} | ||
@@ -6899,6 +6902,10 @@ ssize_t nghttp2_session_mem_recv(nghttp2_session *session, const uint8_t *in, | ||
} | ||
#endif /* DEBUGBUILD */ | ||
|
||
+ if (++session->num_continuations > session->max_continuations) { | ||
+ return NGHTTP2_ERR_TOO_MANY_CONTINUATIONS; | ||
+ } | ||
+ | ||
readlen = inbound_frame_buf_read(iframe, in, last); | ||
in += readlen; | ||
|
||
diff --git a/lib/nghttp2/lib/nghttp2_session.h b/lib/nghttp2/lib/nghttp2_session.h | ||
index b119329a0..ef8f7b27d 100644 | ||
--- a/lib/nghttp2/lib/nghttp2_session.h | ||
+++ b/lib/nghttp2/lib/nghttp2_session.h | ||
@@ -110,6 +110,10 @@ typedef struct { | ||
#define NGHTTP2_DEFAULT_STREAM_RESET_BURST 1000 | ||
#define NGHTTP2_DEFAULT_STREAM_RESET_RATE 33 | ||
|
||
+/* The default max number of CONTINUATION frames following an incoming | ||
+ HEADER frame. */ | ||
+#define NGHTTP2_DEFAULT_MAX_CONTINUATIONS 8 | ||
+ | ||
/* Internal state when receiving incoming frame */ | ||
typedef enum { | ||
/* Receiving frame header */ | ||
@@ -290,6 +294,12 @@ struct nghttp2_session { | ||
size_t max_send_header_block_length; | ||
/* The maximum number of settings accepted per SETTINGS frame. */ | ||
size_t max_settings; | ||
+ /* The maximum number of CONTINUATION frames following an incoming | ||
+ HEADER frame. */ | ||
+ size_t max_continuations; | ||
+ /* The number of CONTINUATION frames following an incoming HEADER | ||
+ frame. This variable is reset when END_HEADERS flag is seen. */ | ||
+ size_t num_continuations; | ||
/* Next Stream ID. Made unsigned int to detect >= (1 << 31). */ | ||
uint32_t next_stream_id; | ||
/* The last stream ID this session initiated. For client session, |
Oops, something went wrong.