Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Feature Flag to RoboCopy in WindowsMachineFileCopyV2 #20746

Merged

Conversation

EshitaD
Copy link
Contributor

@EshitaD EshitaD commented Dec 23, 2024

Task name: WindowsMachineFileCopyV2

Description: After enabling this feature flag, Robocopy will retry three times because, by default, Robocopy has a 1-million retry limit.

There is an additional argument input in the task where customers can specify their desired retry values. If they enable the feature flag, the task will use 3 retries by default; otherwise, it will default to 1 million retries.
There is another case where a customer enables the feature flag (resulting in 3 retries by default) and also specifies 5 retries in the additional argument. In this case, the task will use 5 retries as the provided value takes precedence.
image

Documentation changes required: (Y/N)

Added unit tests: (Y/N)

Attached related issue: BUG

Checklist:

  • Task version was bumped - please check instruction how to do it
  • Checked that applied changes work as expected

@EshitaD EshitaD requested review from manolerazvan and a team as code owners December 23, 2024 05:38
@z00sts z00sts self-requested a review December 31, 2024 09:24
Copy link
Contributor

@z00sts z00sts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EshitaD EshitaD merged commit 93a10ac into master Dec 31, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants