updated the delete conditions for removing an app's persistent volume

[alexlianides]

updated the delete conditions for removing an app's persistent volume only if the reclaim policy is "Retain". Otherwise, k3s delete the volume automatically via deletion of the volume claim

[bigtallcampbell]

The claim name is pulling from the wrong spot. For example, the results for hostsvc-link query you've got would be:

ryan@ryan-dev1:~/azure-orbital-space-sdk-setup$ kubectl get persistentvolume --output json -A | jq -r '.items[] | select(.metadata.labels."microsoft.azureorbital/appName" == "hostsvc-link") | {pv_name: .metadata.name, pv_namespace: .metadata.namespace, volume_name: .spec.volumeName, volume_reclaim_policy: .spec.persistentVolumeReClaimPolicy}'
{
  "pv_name": "hostsvc-link-xfer-pv",
  "pv_namespace": null,
  "volume_name": null,
  "volume_reclaim_policy": null
}
{
  "pv_name": "hostsvc-link-plugins-pv",
  "pv_namespace": null,
  "volume_name": null,
  "volume_reclaim_policy": null
}
{
  "pv_name": "hostsvc-link-allxfer-pv",
  "pv_namespace": null,
  "volume_name": null,
  "volume_reclaim_policy": null
}

It should be:

kubectl get persistentvolume --output json -A | jq -r '.items[] | select(.metadata.labels."microsoft.azureorbital/appName" == "hostsvc-link") | {pv_name: .metadata.name, volume_name: .spec.claimRef.name, volume_namespace: .spec.claimRef.namespace, volume_reclaim_policy: .spec.persistentVolumeReclaimPolicy}'
{
  "pv_name": "hostsvc-link-xfer-pv",
  "volume_name": "hostsvc-link-xfer-pvc",
  "volume_namespace": "hostsvc",
  "volume_reclaim_policy": "Delete"
}
{
  "pv_name": "hostsvc-link-plugins-pv",
  "volume_name": "hostsvc-link-plugins-pvc",
  "volume_namespace": "hostsvc",
  "volume_reclaim_policy": "Delete"
}
{
  "pv_name": "hostsvc-link-allxfer-pv",
  "volume_name": "hostsvc-link-allxfer-pvc",
  "volume_namespace": "hostsvc",
  "volume_reclaim_policy": "Delete"
}

Notable changes:

• Namespace variable is updated for persistentvolumeclaim (PersistentVolumes don't have namespaces)
• Typo correction on Volume Reclaim Policy
• Variable name update

Once updated, you'll need to update line #46 and change the `kubectl delete persistentvolumeclaim' to use the volume_name and volume_namespace. Currently it's trying to delete the persistentvolumeclaim that matches the volume name.