Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update abstract_markdown_browser.py #4850

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

D-Yuva
Copy link

@D-Yuva D-Yuva commented Dec 29, 2024

Why are these changes needed?

This PR introduces three new abstract methods to enhance the functionality of the AbstractMarkdownBrowser class:

  1. extract_tables: Extracts tables from Markdown content, enabling structured data analysis.
  2. wait_for_render: Ensures dynamic content is fully rendered before processing, accommodating JavaScript-heavy pages.
  3. get_logs: Retrieves logs of browser activities and errors to assist with debugging and issue tracking.

Related issue number

None. This is a new feature enhancement.

Checks

1. extract_tables(self) -> list
This method is designed to extract tables from the Markdown content and return them as Python objects.

2. wait_for_render(self, timeout: int) -> None
This method ensures that dynamic web content is fully rendered before extracting the page's Markdown. 

3. get_logs(self) -> list
This method allows developers to retrieve logs of browser activities and errors.
@D-Yuva
Copy link
Author

D-Yuva commented Dec 29, 2024

@microsoft-github-policy-service agree

@ekzhu ekzhu requested a review from afourney December 29, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant