-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add coverage task & integrate with poe check #4847
Conversation
@ekzhu here you go. Do we want to enforce some coverage level with something like |
Thank you! @srjoglekar246 I am wondering if we can run this in CI automatically on a PR and publish the result as a message to the PR? The v0.2 branch does this: autogen/.github/workflows/build.yml Lines 106 to 111 in 38bfb3d
More documentation on code cov action: https://github.com/marketplace/actions/codecov I think we should update this part of checks.yml: autogen/.github/workflows/checks.yml Lines 105 to 133 in 6e0f65b
The code coverage result can be viewed here: https://app.codecov.io/github/microsoft/autogen. Since we haven't been running the v0.2 branch for several months, it is outdated information on it. |
ec4324c
to
2086fb5
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4847 +/- ##
===========================================
+ Coverage 30.49% 68.21% +37.71%
===========================================
Files 113 158 +45
Lines 12284 9960 -2324
Branches 2602 0 -2602
===========================================
+ Hits 3746 6794 +3048
+ Misses 8210 3166 -5044
+ Partials 328 0 -328
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
5b6ab43
to
931f967
Compare
931f967
to
0379a30
Compare
@ekzhu @jackgerrits Looks like code coverage is working fine, can you take a look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great! Thanks!
cc @victordibia we may need to add studio package to the coverage list also.
Does the coverage report need to be merged before it is reported to codecov? Or is codecov able to merge the reports across the repo? |
I think it needs to be merged to main first before we can get new report base. The current base is from several months ago: https://app.codecov.io/gh/microsoft/autogen |
Oh sorry my wording was ambiguous. I meant that this PR is producing many reports and sending them all independently to codecov. Do they need to be combined into a single coverage report for the given pr/commit? What do the codecov docs say on this? |
Looks like it might be automatic: https://docs.codecov.com/docs/github-4a-merging-reports |
We might want to ignore samples and tests though https://docs.codecov.com/docs/code-coverage-with-python |
So adding a |
It must be a single file at the root of the repo https://docs.codecov.com/docs/codecov-yaml#can-i-name-the-file-codecovyml |
Why are these changes needed?
Adds code coverage checks for autogen
Related issue number
Closes #4477
Checks