[New resource] IntuneMobileAppConfigurationPolicyIos #5401
Conversation
Untested
Export appears to be working for "settings"
Module is affected by issue microsoft#5396. Replace ` with " in M365TenantConfig.ps1 is your configuration key values contain double quotes. Otherwise, it should work as expected.
|
Same comment as for your other PR:
Also we need an entry of this new resource in the changelog: https://github.com/microsoft/Microsoft365DSC/blob/Dev/CHANGELOG.md Could you please add these items to the PR? |
create,update and remove examples added
|
Added unit test, examples and updated change log. Hopefully I did it right?! |
|
Do not see the updated changelog yet. Could you please check? |
| "delegated": { | ||
| "read": [ | ||
| { | ||
| "name": "DeviceManagementApps.Read.All" | ||
| } | ||
| ], | ||
| "update": [ | ||
| { | ||
| "name": "DeviceManagementApps.ReadWrite.All" | ||
| } | ||
| ] | ||
| }, | ||
| "application": { | ||
| "read": [ | ||
| { | ||
| "name": "DeviceManagementApps.Read.All" | ||
| } | ||
| ], | ||
| "update": [ | ||
| { | ||
| "name": "DeviceManagementApps.ReadWrite.All" | ||
| } | ||
| ] | ||
| } | ||
| } |
There was a problem hiding this comment.
Because we're dealing with Intune assignments, an additional entry for Group.Read.All is required. You can take at the other Intune resources.
There was a problem hiding this comment.
should be resolved in latest pull request
...s/MSFT_IntuneMobileAppConfigurationPolicyIOS/MSFT_IntuneMobileAppConfigurationPolicyIOS.psm1
Show resolved
Hide resolved
Group.Read.All permission added to settings.json Excessive number of blank lines reduced for readability.
should be resolved in latest pull request |
There was a problem hiding this comment.
@dannyKBjj You don't need a separate pull request just for the changelog, adding it here (just as you did) is fine. Although you can omit the MSFT_ prefix in front of the resource name and place it in order 😃
..._IntuneMobileAppConfigurationPolicyIOS/MSFT_IntuneMobileAppConfigurationPolicyIOS.schema.mof
Outdated
Show resolved
Hide resolved
...s/MSFT_IntuneMobileAppConfigurationPolicyIOS/MSFT_IntuneMobileAppConfigurationPolicyIOS.psm1
Outdated
Show resolved
Hide resolved
...s/MSFT_IntuneMobileAppConfigurationPolicyIOS/MSFT_IntuneMobileAppConfigurationPolicyIOS.psm1
Outdated
Show resolved
Hide resolved
…gurationPolicyIOS/MSFT_IntuneMobileAppConfigurationPolicyIOS.psm1 Co-authored-by: FabienTschanz <[email protected]>
…gurationPolicyIOS/MSFT_IntuneMobileAppConfigurationPolicyIOS.psm1 Co-authored-by: FabienTschanz <[email protected]>
…github.com/dannyKBjj/Microsoft365DSC into MSFT_IntuneMobileAppConfigurationPolicyIOS
CHANGELOG.md
Outdated
| @@ -23,6 +23,8 @@ | |||
| * DEPENDENCIES | |||
| * Updated DSCParser to version 2.0.0.12. | |||
| * Updated MSCloudLoginAssistant to version 1.1.28. | |||
| * MSFT_IntuneMobileAppConfigurationPolicyIOS | |||
There was a problem hiding this comment.
Please remove the MSFT_ prefix and then place this entry in alphabetical order in the list
|
Fixed 2-Update.ps1 example. Should now pass unit tests. |
|
Unsure how best to resolve CHANGELOG.md conflict? |
ykuijs
changed the title
|
Hi, see issue #5587 as I believe this module fixes the issue. Have created pull request to re-instate my module and remove the one that this duplicated. Android apps are handled by the module IntuneAndroidManagedStoreAppConfiguration (which I also submitted), but for some reason this was never removed. Issue #5587 for module "IntuneAppConfigurationDevicePolicy" seems to be caused by the logic the combined resource uses to determine the application assignment. The separated resources do not have this problem. |
Pull Request (PR) description
This Pull Request (PR) fixes the following issues