-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][ci] added docs about GPU support out of the box for Windows wheels and small refactoring for dual test #3660
Conversation
@@ -77,9 +77,9 @@ OpenCL SDK Installation | |||
Installing the appropriate OpenCL SDK requires you to download the correct vendor source SDK. | |||
You need to know what you are going to use LightGBM! | |||
|
|||
- For running on Intel, get `Intel SDK for OpenCL`_ (NOT RECOMMENDED). | |||
- For running on Intel, get `Intel SDK for OpenCL`_ (**NOT RECOMMENDED**). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tpboudreau I think this is the reason why Intel OpenCL Runtime behaves oddly at Azure.
I've run against the python package using three different versions the Intel CPU OpenCL platform. They all run successfully and give reasonable results, but for some reason they either sporadically hang at shutdown or terminate with the user script returning 'False'.
Warning: using Intel OpenCL is not recommended and may crash your machine due to being non compliant to OpenCL standards.
Overall, looks great. Just two small suggestions. And one quick question, just to clarify: will the published PyPI wheel now be built with the --integrated-opencl flag, or is there some other change or PR required? (I haven't forgotten that I'm going it to look into getting that build to default to device=gpu for the CI tests. I'll get to that as soon as I can.) |
Co-authored-by: TP Boudreau <[email protected]>
Thanks! Applied!
Yeah! Actually, nightly releases are being built with this flag right now. You can check it. https://lightgbm.readthedocs.io/en/latest/Installation-Guide.html Yesterday I run a few tests with them on my local machine with NVIDIA GPU and didn't notice any problems except the difference in returned results. For ordinary releases we just take nightly artifacts for particular commit. Lines 179 to 195 in 46986ba
Great! Many thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All looks great to me!
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Continuation of #3403.
@tpboudreau Please help with review.