[R-package] add new copyright holder in DESCRIPTION #3409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikerRUS
requested changes
Sep 26, 2020
R-package/DESCRIPTION
Outdated
| @@ -7,7 +7,8 @@ Authors@R: c( | |||
| person("Guolin", "Ke", email = "[email protected]", role = c("aut", "cre")), | |||
| person("Damien", "Soukhavong", email = "[email protected]", role = c("aut")), | |||
| person("Yachen", "Yan", role = c("ctb")), | |||
| person("James", "Lamb", email="[email protected]", role = c("aut")) | |||
| person("James", "Lamb", email="[email protected]", role = c("aut")), | |||
| person("IBM Corporation", role = c("IBM Corporation")) | |||
There was a problem hiding this comment.
role should be ctb or aut I believe.
There was a problem hiding this comment.
ha of course! I did this too fast, sorry
StrikerRUS
approved these changes
Sep 26, 2020
jameslamb
added a commit
to jameslamb/LightGBM
that referenced
this pull request
Sep 30, 2020
* [R-package] add new copyright holder in DESCRIPTION * fix role
jameslamb
added a commit
to jameslamb/LightGBM
that referenced
this pull request
Sep 30, 2020
* [R-package] add new copyright holder in DESCRIPTION * fix role
jameslamb
added a commit
that referenced
this pull request
Oct 8, 2020
…3338) * [R-package] update DESCRIPTION per CRAN comments * newlines * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * more fixes * update Rbuildignore * more changes * more changes per CRAN response * add email * run examples in CI * add newest CRAN response * add Solaris patch * update patch * another attempt at ifaddrs patch * fix unnecessary comment * update configure * comments * bump version * tabs * fix address alignment, required by cran (#3415) * fix dataset binary file alignment * many fixes * fix warnings * fix bug * Update file_io.cpp * Update file_io.cpp * simplify code * Apply suggestions from code review * general * remove unneeded alignment * Update file_io.h * int32 to byte8 alignment * Apply suggestions from code review * Apply suggestions from code review * [R-package] add new copyright holder in DESCRIPTION (#3409) * [R-package] add new copyright holder in DESCRIPTION * fix role * fixing conflicts * [R-package] add new copyright holder in DESCRIPTION (#3409) * [R-package] add new copyright holder in DESCRIPTION * fix role * trying to fix conflicts * more fixes * this will work * update cran-comments * simplify solaris, add more testing docs * stuff * remove rchck docs * Apply suggestions from code review Co-authored-by: Nikita Titov <[email protected]> * remove extra use of cat() * change solaris check * update docs * remove testing code * fix warning about cleanup not having execute permissions * fix cmake builds * remove blank line Co-authored-by: Nikita Titov <[email protected]> Co-authored-by: Guolin Ke <[email protected]>
|
This pull request has been automatically locked since there has not been any recent activity since it was closed. To start a new related discussion, open a new issue at https://github.com/microsoft/LightGBM/issues including a reference to this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #3338 , we learned from CRAN that all copyright holders of any part of the source code need to be listed in the R package's
DESCRIPTIONfile.Since #3160 added some code with an IBM copyright on it, IBM needs to be added to
DESCRIPTION. #3338 (comment)