Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for CUDA-based GPU build #3160
Add support for CUDA-based GPU build #3160
Changes from all commits
328a9f0
895d6e4
fc981bf
581ce4a
3f98c73
2ec9a41
1023182
e50e4be
3d62018
7a6bf33
01b3226
64dbb6b
e17b345
32825e5
169a734
3c83274
5b3f36a
91a312f
b05afeb
0136317
f4b1057
82e4968
512a0a3
29f6979
4d89fd7
e10a467
911c1b3
1870480
37a1a61
fcf031c
0fb433f
44819a4
a668c8e
0e8cd92
0cbe79d
252f465
f7d8fb4
be09b8f
3d6addd
0025bed
b70604d
d92739d
429e752
c7c22a5
aad98f0
1aabb5c
f75696e
0f6df0b
8fa8318
f70beb7
af49c32
038128d
3fd7618
7e692c2
b27b7e1
80a8f43
baf6f79
944a3e5
f34ec35
44ce402
d7e34de
8af3738
903e52b
1efcad0
13c6450
7a6bbb5
55f24cc
8e028f3
f4725e1
0e84c15
ccf7602
c417715
bdcbeaa
930436c
312733d
943603a
1842c82
7a79697
f37ab3b
9ff6a2b
e0ad9d5
90709e6
99e459b
f40d77b
d900b64
361720b
a8b4245
ac5f7b8
63d75e9
6fee44a
cc41446
bab89cf
ea96902
12a9fe5
d712538
26c4dce
70b4bbb
e7f45f5
282731c
6103a87
40e37e8
8878ea4
9ab44b6
9f8a011
766a514
5369a8a
51e096c
9ca091b
7fcecff
05274d4
8bb20d3
f0ebfa6
cc6d348
5f3f1e0
676807a
a751bea
15eec67
1884dc2
32f3a8d
cc09d48
2095e9a
6b3cc5c
ea537f8
d9e9d2e
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be moved to https://github.com/microsoft/LightGBM/blob/master/src/io/config.cpp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like duplication.
I'm maybe missing something but why can't we compare directly
config_->device_type == std::string("cuda")
? Could you please elaborate why this proxy construction is needed?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think it is available in all the places CUDA needs it. If you want to investigate this once it is integrated, please do.