Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMake update to avoid directxmath subdir for include #224

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

walbourn
Copy link
Member

@walbourn walbourn commented Nov 27, 2024

When using MSBuild+VCPKG, it required code changes in the client code to reference the DirectXMath headers properly which was not an issue for CMake+VCPKG.

This change removes the directxmath part of include/directxmath for the installed directory. Since these headers don't conflict with other ports, this works fine.

Note that directxtex, directxmesh, and uvatlas already follow this pattern (i.e. just install to include not a subdir). directxtk, directxk12 have the same header names, so they really have to be in subdirs.

@walbourn walbourn merged commit 78922ff into main Dec 2, 2024
102 checks passed
@walbourn walbourn deleted the cmakeupdate branch December 2, 2024 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants