Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Triton 2.2+ #4937

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Support Triton 2.2+ #4937

wants to merge 10 commits into from

Conversation

loadams
Copy link
Contributor

@loadams loadams commented Jan 11, 2024

No description provided.

@loadams loadams requested a review from mrwyattii as a code owner January 11, 2024 17:45
@loadams loadams requested a review from stephen-youn January 11, 2024 20:25
@YizhouZ
Copy link
Contributor

YizhouZ commented Jan 12, 2024

Hi, may I know this upgrading triton will also adjust triton kernels? #4857

Thanks!

@loadams
Copy link
Contributor Author

loadams commented Jan 12, 2024

Hi, may I know this upgrading triton will also adjust triton kernels? #4857

Thanks!

Hi @YizhouZ - the main goal here was just to add what is needed to fix our nv-inference tests (currently failing above) when using the newly published triton 2.2. For now we have pinned to 2.1 but this effort is to allow us to use 2.2, I probably won't adjust the kernels in this PR as well.

@YizhouZ
Copy link
Contributor

YizhouZ commented Jan 15, 2024

Hi, may I know this upgrading triton will also adjust triton kernels? #4857
Thanks!

Hi @YizhouZ - the main goal here was just to add what is needed to fix our nv-inference tests (currently failing above) when using the newly published triton 2.2. For now we have pinned to 2.1 but this effort is to allow us to use 2.2, I probably won't adjust the kernels in this PR as well.

Understood. May I know if there is any plan to upgrade kernel for triton-2.2?

@stephen-youn
Copy link
Contributor

stephen-youn commented Feb 21, 2024

It would be worth to manually run and to check the following pytests in deepspeed with the latest 2.2 triton
image

@loadams loadams self-assigned this Jan 13, 2025
@loadams loadams requested review from Copilot and removed request for stephen-youn and mrwyattii January 13, 2025 19:18

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

Files not reviewed (1)
  • requirements/requirements-triton.txt: Language not supported
@@ -58,7 +58,7 @@ jobs:
run: |
unset TORCH_CUDA_ARCH_LIST # only jit compile for current arch
cd tests
#pytest $PYTEST_OPTS -m 'seq_inference' unit/ --torch_ver="2.1" --cuda_ver="12.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: Need to confirm this test actually runs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants