-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Triton 2.2+ #4937
base: master
Are you sure you want to change the base?
Support Triton 2.2+ #4937
Conversation
Hi, may I know this upgrading triton will also adjust triton kernels? #4857 Thanks! |
Hi @YizhouZ - the main goal here was just to add what is needed to fix our nv-inference tests (currently failing above) when using the newly published triton 2.2. For now we have pinned to 2.1 but this effort is to allow us to use 2.2, I probably won't adjust the kernels in this PR as well. |
Understood. May I know if there is any plan to upgrade kernel for triton-2.2? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Files not reviewed (1)
- requirements/requirements-triton.txt: Language not supported
@@ -58,7 +58,7 @@ jobs: | |||
run: | | |||
unset TORCH_CUDA_ARCH_LIST # only jit compile for current arch | |||
cd tests | |||
#pytest $PYTEST_OPTS -m 'seq_inference' unit/ --torch_ver="2.1" --cuda_ver="12.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO: Need to confirm this test actually runs.
No description provided.