#27057 EDocument Connector for Tietoevry #27233

[Roglar01]

E-Documents connector interface implementation between Business Central and Tietoevry

Work Item(s)
Fixes #27057
Fixes AB#541808

[Groenbech96]

New interface will break build as we discussed. The filenames do not follow code convention :)

[Roglar01]

@Groenbech96 I know. Work in progress here. Will update next week.

[Groenbech96]

Very cool, good start. Will review further later.

[Groenbech96]

Error: AA0215 The file Objects.PermissionSet.al has an incorrect name. The valid name is TietoevryObjects.PermissionSet.al.
Error: AA0215 The file Read.PermissionSet.al has an incorrect name. The valid name is TietoevryRead.PermissionSet.al.
Error: AA0215 The file Edit.PermissionSet.al has an incorrect name. The valid name is TietoevryEdit.PermissionSet.al.
Error: AA0215 The file TeitoevryEDocConnectorEdit.PermissionSetExt.al has an incorrect name. The valid name is TietoevryEDocConnectorEdit.PermissionSetExt.al.
Error: AA0215 The file EDocFormat.EnumExt.al has an incorrect name. The valid name is EDocFormatExt.EnumExt.al.
Error: AA0215 The file EDocumentImpl.al has an incorrect name. The valid name is TietoevryEDocument.Codeunit.al.
Error: AA0215 The file Cod6398.FormatEvents.al has an incorrect name. The valid name is FormatEvents.Codeunit.al.
Error: AA0215 The file TietoevryEDocImport.al has an incorrect name. The valid name is TietoevryEDocumentImport.Codeunit.al.
Error: AA0137 Variable 'EDocumentAttachmentGen' is unused in '"Tietoevry E-Document Import"'.
Error: AA0137 Variable 'EDocument' is unused in 'ParseCreditMemo'.
Error: AA0137 Variable 'EDocument' is unused in 'ParseInvoice'.

[Roglar01]

In file /Formats/TietoevryEDocImport.Codeunit I have an issue with the fact that the protection level on EDocumentAttachmentGen.Insert() procedure makes me unable to use it from this app. Can you consider changing the protection level (from internal to public), allowing me to complete the format implementation without duplicating code? "pragma warning disable AA0137" is there to suppress all warnings related to this. @Groenbech96

[Groenbech96]

Pull the commit i made above.
Left comments on the rest.

[pri-kise]

If I understand this event subscriber correctly then this will always change the content as soon as a connectionsetup exists and an e-document service exists for tietoevry.

Is there any chance to find out if this document will be transferred via this e document service?

If this isn't possible then there should be other mechanism to prevent conflicts with other e document services that might be installed in parallel.

[Roglar01]

No, the code exits if there is no Service Integration to Tietoevry.. if not IsBISBilling then exit; if not ConnectionSetup.Get() then exit; EDocumentService.SetRange("Service Integration V2", EDocumentService."Service Integration V2"::Tietoevry); if not EDocumentService.FindFirst() then exit; From: Kilian Seizinger ***@***.***> Sent: Wednesday, December 18, 2024 8:02 AM To: microsoft/ALAppExtensions ***@***.***> Cc: Roger Larsson ***@***.***>; Author ***@***.***> Subject: Re: [microsoft/ALAppExtensions] #27057 EDocument Connector for Tietoevry #27233 (PR #27626) @pri-kise commented on this pull request.

________________________________ In Apps/W1/EDocumentConnectors/Tietoevry/app/src/Formats/FormatEvents.Codeunit.al<#27626 (comment)>:

+ EDocumentService.SetRange("Service Integration V2", EDocumentService."Service Integration V2"::Tietoevry);

+ if not EDocumentService.FindFirst() then + exit; + ServiceParticipant.Get(EDocumentService.Code, ServiceParticipant."Participant Type"::Customer, SalesHeader."Bill-to Customer No."); + this.SplitId(ServiceParticipant."Participant Identifier", CustomerSchemeID, CustomerEndpointID); + this.SplitId(ServiceParticipant."Participant Identifier", CustomerPartyIDSchemeID, CustomerPartyIdentificationID); + end; + + [EventSubscriber(ObjectType::Codeunit, Codeunit::"PEPPOL Management", OnAfterGetAccountingCustomerPartyLegalEntityByFormat, '', false, false)] + local procedure "PEPPOL Management_OnAfterGetAccountingCustomerPartyLegalEntityByFormat"(SalesHeader: Record "Sales Header"; var CustPartyLegalEntityRegName: Text; var CustPartyLegalEntityCompanyID: Text; var CustPartyLegalEntityIDSchemeID: Text; IsBISBilling: Boolean) + var + ServiceParticipant: Record "Service Participant"; + EDocumentService: Record "E-Document Service"; + ConnectionSetup: Record "Connection Setup"; + begin + if not IsBISBilling then If I understand this event subscriber correctly then this will always change the content as soon as a connectionsetup exists and an e-document service exists for tietoevry. Is there any chance to find out if this document will be transferred via this e document service? If this isn't possible then there should be other mechanism to prevent conflicts with other e document services that might be installed in parallel. - Reply to this email directly, view it on GitHub<#27626 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZCUPSGNJ4IBFPWQ2BN4RFT2GEMU3AVCNFSM6AAAAABRWNAJHWVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKMJQHE3DEMJSGE>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>>

[DanielGoehler]

No, the code exits if there is no Service Integration to Tietoevry.. if not IsBISBilling then exit; if not ConnectionSetup.Get() then exit; EDocumentService.SetRange("Service Integration V2", EDocumentService."Service Integration V2"::Tietoevry); if not EDocumentService.FindFirst() then exit;

@Roglar01 Your response seems rather quick. In FormatEvents.Codeunit.al, there are several cases where checks are missing in "PEPPOL Management_OnAfterGetAccountingSupplierPartyLegalEntityByFormat" and "PEPPOL Management_OnAfterGetAccountingSupplierPartyInfoByFormat". Additionally, you should verify whether the export is intended for your specific service.

What happens if a customer uses multiple integrations? Will your code still be executed inappropriately in such cases?

[Roglar01]

"Your response seems rather quick" Your point? The code is based on your Avalara-connector. Best regards, Roger Larsson Application Development Lead Tietoevry Tech Services, Sweden Mobile +46 72 181 7087 Storgatan 19, 753 31 Uppsala ***@***.******@***.***> From: Daniel Göhler ***@***.***> Sent: Monday, December 23, 2024 1:47 PM To: microsoft/ALAppExtensions ***@***.***> Cc: Roger Larsson ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/ALAppExtensions] #27057 EDocument Connector for Tietoevry #27233 (PR #27626) No, the code exits if there is no Service Integration to Tietoevry.. if not IsBISBilling then exit; if not ConnectionSetup.Get() then exit; EDocumentService.SetRange("Service Integration V2", EDocumentService."Service Integration V2"::Tietoevry); if not EDocumentService.FindFirst() then exit; @Roglar01<https://github.com/Roglar01> Your response seems rather quick. In FormatEvents.Codeunit.al, there are several cases where checks are missing in "PEPPOL Management_OnAfterGetAccountingSupplierPartyLegalEntityByFormat" and "PEPPOL Management_OnAfterGetAccountingSupplierPartyInfoByFormat". Additionally, you should verify whether the export is intended for your specific service. What happens if a customer uses multiple integrations? Will your code still be executed inappropriately in such cases? - Reply to this email directly, view it on GitHub<#27626 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZCUPSD6XALYLQSKNEAA6OL2HAA57AVCNFSM6AAAAABRWNAJHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJZGY2DMNJWGM>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[DanielGoehler]

@Roglar01 The situation is even worse. You blindly copied this poor design and refuse to take responsibility for your code.

[Roglar01]

As per suggested by you at Microsoft, we created used your code as a baseline for our connector. @magnus Hartvig ***@***.***> I really don't understand why you are so hostile to us for contributing to your product? Best regards, Roger Larsson Application Development Lead Tietoevry Tech Services, Sweden Mobile +46 72 181 7087 Storgatan 19, 753 31 Uppsala ***@***.******@***.***> From: Daniel Göhler ***@***.***> Sent: Monday, December 23, 2024 1:57 PM To: microsoft/ALAppExtensions ***@***.***> Cc: Roger Larsson ***@***.***>; Mention ***@***.***> Subject: Re: [microsoft/ALAppExtensions] #27057 EDocument Connector for Tietoevry #27233 (PR #27626) @Roglar01<https://github.com/Roglar01> The situation is even worse. You blindly copied this poor design and refuse to take responsibility for your code. - Reply to this email directly, view it on GitHub<#27626 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AZCUPSB5GBQD4FWUPKMU4DD2HACANAVCNFSM6AAAAABRWNAJHWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNJZGY3DAOJSGI>. You are receiving this because you were mentioned.Message ID: ***@***.******@***.***>>

[DanielGoehler]

@Roglar01 My remarks are not meant to be hostile; I apologize if they came across that way. However, I am indeed frustrated because if this code, as it stands, ends up in Business Central, and my customers experience issues, I will be the one dealing with troubleshooting, creating a Microsoft support case, and waiting for a fix. Meanwhile, my customers will be upset, questioning why there isn’t better quality control at Microsoft for updates.

[DanielGoehler]

@Roglar01 You mentioned that you used the Avalara Connector as a baseline. I took a quick look and didn’t notice any problematic event subscribers. (If I had, I would have suggested to the product team that those should be fixed as well.)

[DanielGoehler]

@Groenbech96 Will the Tietoevry Conncetor App be automatically installed in the next update after the pull request is completed, or will it require manual installation via AppSource?

[Groenbech96]

@DanielGoehler thanks for bringing this point up. Very true, that these event subscribers in the current form are problematic, as we intend to install the app per default.

Any ideas on how to fix this? I will spend some time to think and discuss this one with the team.

[DanielGoehler]

Any ideas on how to fix this? I will spend some time to think and discuss this one with the team.

To integrate the E-Document Service with the Codeunit PEPPOL Validation, I suggest the following steps:

1. Add the E-Document Service to the Codeunit PEPPOL Validation.

2. Include the E-Document Service in the following events:

   • OnCheckSalesDocumentOnBeforeCheckCompanyVATRegNo
   • OnCheckSalesDocumentOnBeforeCheckCustomerVATRegNo
   • OnAfterGetAccountingSupplierPartyInfoByFormat
   • OnAfterGetAccountingSupplierPartyLegalEntityByFormat
   • OnAfterGetAccountingCustomerPartyInfoByFormat
   • OnAfterGetAccountingCustomerPartyLegalEntityByFormat

3. For each event subscriber, include the following initial line of code to ensure the correct service integration:

   if not EDocumentService."Service Integration V2" = EDocumentService."Service Integration V2"::Tietoevry then
     exit;

This approach ensures that only the Tietoevry service integration is processed while maintaining clarity and modularity in your implementation.

I have not yet investigated why this is necessary, but for the OnBeforeExportDataStorage event, I recommend adding the following checks to ensure this code executes only for the Tietoevry Service:

[EventSubscriber(ObjectType::Table, Database::"E-Document Log", 'OnBeforeExportDataStorage', '', false, false)]
local procedure SetFileExt(EDocumentLog: Record "E-Document Log"; var FileName: Text)
var
    //+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    EDocumentService: Record "E-Document Service";
    //-------------------------------------------------------------
begin
    //+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
    if not EDocumentService.Get(EDocumentLog."Service Code") then
        exit;

    if not EDocumentService."Service Integration V2" = EDocumentService."Service Integration V2"::Tietoevry then
        exit;
    //-------------------------------------------------------------
    FileName += '.xml';
end;"

[JesperSchulz]

@Groenbech96 Will the Tietoevry Conncetor App be automatically installed in the next update after the pull request is completed, or will it require manual installation via AppSource?

@DanielGoehler, we are going to discuss this. There have been more than one discussion lately, to which extend it could be beneficial not to force-install certain apps going forward. Maybe a wizard-experience could be envisioned, which only installs the pre-published connectors if necessary? I don't know the details about the e-document capabilities, but I'll for sure bring forward the points which have been made in this discussion. If we could achieve the same seamless setup and integration without preinstalling conditional apps, I think it could be preferable. But we'll have to look into if we can actually achieve that with what we've got today.