-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix header location for zephyr 3.2 for udp. #117
base: humble
Are you sure you want to change the base?
Fix header location for zephyr 3.2 for udp. #117
Conversation
@mergify backport main foxy galactic |
🟠 Waiting for conditions to match
|
This will be merged when Zephyr 3.2 is supported |
@pablogs9 are there plans to support zephyr 3.2 in the near future? Was hoping we could get this PR merged in. |
@Acuadros95 do we support 3.1 right? Is possible to update to 3.2 as @cmorganBE mentions? |
I was actually trying to test against 3.3 (the latest stable release) and was running into boatloads of warnings as the old headers are nearing removal. Was planning at least to fire up a ethernet based test to test round trip time etc. I had to make some other changes to get things to compile but I'm not sure if this PR will fix those yet, plan to re-test as soon as its merged. |
PTAL @Acuadros95 |
@@ -18,8 +18,13 @@ | |||
#include <unistd.h> | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#include <version.h> |
We need to include the version.h
file to use ZEPHYR_VERSION after
Not sure if the module is ready for Zephyr 3.2 yet, but here is a fix for compilation for udp. Serial transport not affected.
Changelog of zephyr 3.2 specifies this:
https://docs.zephyrproject.org/3.2.0/releases/release-notes-3.2.html
Documentation:
https://docs.zephyrproject.org/3.2.0/releases/release-notes-3.2.html
Edit 1:
Added to prj.conf for testing udp(compile only):