Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linebreak processing in MathML in Presentation XML: https://github.co… #556

Merged
merged 4 commits into from
Dec 21, 2023

Conversation

opoudjis
Copy link
Contributor

…m/metanorma/metanorma-standoc/issues/111

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Dec 19, 2023
end

context "overrides localisation of numbers in MathML" do
it "overrides localisation of numbers in MathML, with no grouping of digits" do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [83/80]

end

it "Supports twitter_cldr_localiser_symbols fraction options" do
expect(xmlpp(strip_guid(IsoDoc::PresentationXMLConvert.new(presxml_options)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [81/80]

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (08f0d10) 95.77% compared to head (ae0c666) 95.83%.
Report is 1 commits behind head on main.

Files Patch % Lines
lib/isodoc/presentation_function/metadata.rb 97.59% 2 Missing ⚠️
lib/isodoc/presentation_function/math.rb 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
+ Coverage   95.77%   95.83%   +0.05%     
==========================================
  Files          77       78       +1     
  Lines        5379     5403      +24     
==========================================
+ Hits         5152     5178      +26     
+ Misses        227      225       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -15,6 +15,11 @@ def convert1(docxml, filename, dir)
end.join("\n")
end

def preprocess_xslt(docxml)

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra empty line detected at method body beginning.

@@ -15,6 +15,11 @@ def convert1(docxml, filename, dir)
end.join("\n")
end

def preprocess_xslt(docxml)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Useless method definition detected.

end
end

def trim_hash1(hash)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cyclomatic complexity for trim_hash1 is too high. [8/6]

end
end

def i8n_name1(hash, pref)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment Branch Condition size for i8n_name1 is too high. [<9, 18, 9> 22.05/15]
Cyclomatic complexity for i8n_name1 is too high. [10/6]
Method has too many lines. [11/10]
Perceived complexity for i8n_name1 is too high. [9/7]

XSLT
end

def passthrough_xslt
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Method has too many lines. [29/10]

@toctables and
ins << "<toc type='table'><title>#{@i18n.toc_tables}</title></toc>"
@tocfigures and
ins << "<toc type='recommendation'><title>#{@i18n.toc_recommendations}" \
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [81/80]

.previous_element
end

def toc_metadata(docxml)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cyclomatic complexity for toc_metadata is too high. [7/6]

@opoudjis opoudjis merged commit d2e1ddc into main Dec 21, 2023
19 of 20 checks passed
@opoudjis opoudjis deleted the fix/math-linebreak branch December 21, 2023 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant