-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Linebreak processing in MathML in Presentation XML: https://github.co… #556
Conversation
end | ||
|
||
context "overrides localisation of numbers in MathML" do | ||
it "overrides localisation of numbers in MathML, with no grouping of digits" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [83/80]
end | ||
|
||
it "Supports twitter_cldr_localiser_symbols fraction options" do | ||
expect(xmlpp(strip_guid(IsoDoc::PresentationXMLConvert.new(presxml_options) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [81/80]
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #556 +/- ##
==========================================
+ Coverage 95.77% 95.83% +0.05%
==========================================
Files 77 78 +1
Lines 5379 5403 +24
==========================================
+ Hits 5152 5178 +26
+ Misses 227 225 -2 ☔ View full report in Codecov by Sentry. |
@@ -15,6 +15,11 @@ def convert1(docxml, filename, dir) | |||
end.join("\n") | |||
end | |||
|
|||
def preprocess_xslt(docxml) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra empty line detected at method body beginning.
@@ -15,6 +15,11 @@ def convert1(docxml, filename, dir) | |||
end.join("\n") | |||
end | |||
|
|||
def preprocess_xslt(docxml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Useless method definition detected.
end | ||
end | ||
|
||
def trim_hash1(hash) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cyclomatic complexity for trim_hash1 is too high. [8/6]
end | ||
end | ||
|
||
def i8n_name1(hash, pref) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Assignment Branch Condition size for i8n_name1 is too high. [<9, 18, 9> 22.05/15]
Cyclomatic complexity for i8n_name1 is too high. [10/6]
Method has too many lines. [11/10]
Perceived complexity for i8n_name1 is too high. [9/7]
XSLT | ||
end | ||
|
||
def passthrough_xslt |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Method has too many lines. [29/10]
@toctables and | ||
ins << "<toc type='table'><title>#{@i18n.toc_tables}</title></toc>" | ||
@tocfigures and | ||
ins << "<toc type='recommendation'><title>#{@i18n.toc_recommendations}" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is too long. [81/80]
.previous_element | ||
end | ||
|
||
def toc_metadata(docxml) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cyclomatic complexity for toc_metadata is too high. [7/6]
…m/metanorma/metanorma-standoc/issues/111
Metanorma PR checklist