Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/i18n yaml inheritance #550

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Fix/i18n yaml inheritance #550

merged 4 commits into from
Nov 29, 2023

Conversation

opoudjis
Copy link
Contributor

Metanorma PR checklist

def extension_insert(xml, path = [])
ins = xml.at(ns("//metanorma-extension")) ||
xml.at(ns("//bibdata"))&.after("<metanorma-extension/>")&.next_element ||
xml.root.elements.first.before("<metanorma-extension/>").previous_element
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [81/80]

docxml.root.elements.first.before("<metanorma-extension/>").previous_element
def extension_insert(xml, path = [])
ins = xml.at(ns("//metanorma-extension")) ||
xml.at(ns("//bibdata"))&.after("<metanorma-extension/>")&.next_element ||
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is too long. [81/80]

ins = docxml.at(ns("//metanorma-extension")) ||
docxml.at(ns("//bibdata"))&.after("<metanorma-extension/>")&.next_element ||
docxml.root.elements.first.before("<metanorma-extension/>").previous_element
def extension_insert(xml, path = [])
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assignment Branch Condition size for extension_insert is too high. [<3, 16, 6> 17.35/15]
Cyclomatic complexity for extension_insert is too high. [7/6]

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7c87979) 95.72% compared to head (034e767) 95.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #550      +/-   ##
==========================================
+ Coverage   95.72%   95.75%   +0.02%     
==========================================
  Files          77       77              
  Lines        5336     5342       +6     
==========================================
+ Hits         5108     5115       +7     
+ Misses        228      227       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opoudjis opoudjis merged commit 2c4f4fa into main Nov 29, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant