Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

https://github.com/metanorma/metanorma-standoc/issues/742 #508

Merged
merged 5 commits into from
Jul 11, 2024

Conversation

opoudjis
Copy link
Contributor

@opoudjis opoudjis commented Apr 13, 2023

metanorma/metanorma-standoc#742

Metanorma PR checklist

@opoudjis opoudjis self-assigned this Apr 13, 2023
@opoudjis opoudjis marked this pull request as draft April 13, 2023 15:27
Copy link

codecov bot commented Nov 30, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (2c4f4fa) 95.75% compared to head (236a55c) 95.60%.

Files Patch % Lines
lib/isodoc/function/blocks.rb 16.66% 5 Missing ⚠️
lib/isodoc/function/to_word_html.rb 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #508      +/-   ##
==========================================
- Coverage   95.75%   95.60%   -0.15%     
==========================================
  Files          77       77              
  Lines        5342     5352      +10     
==========================================
+ Hits         5115     5117       +2     
- Misses        227      235       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@opoudjis opoudjis marked this pull request as ready for review July 10, 2024 14:25
Copy link

@hound hound bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some files could not be reviewed due to errors:

Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` paramete...
Error: RuboCop found unknown Ruby version 3.4 in `TargetRubyVersion` parameter (in .rubocop.yml).
Supported versions: 2.4, 2.5, 2.6, 2.7, 3.0

@opoudjis opoudjis merged commit fc1f879 into main Jul 11, 2024
17 of 18 checks passed
@opoudjis opoudjis deleted the features/bilingual branch July 11, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant