Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add runmariadb script as a shellcheck trigger for mariadb-image #946

Merged
merged 1 commit into from
Jan 13, 2025
Merged

add runmariadb script as a shellcheck trigger for mariadb-image #946

merged 1 commit into from
Jan 13, 2025

Conversation

tuminoid
Copy link
Member

@tuminoid tuminoid commented Jan 9, 2025

Runmariadb script is not a trigger for shellcheck prow job in mariadb-image. Add it.

Another PR is made to mariadb-image to fix the actual shellcheck script.

@tuminoid
add runmariadb script as a shellcheck trigger for mariadb-image
bc76256 
Runmariadb script is not a trigger for shellcheck prow job in
mariadb-image. Add it.

Another PR is made to mariadb-image to fix the actual shellcheck
script.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@metal3-io-bot metal3-io-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 9, 2025
@tuminoid tuminoid mentioned this pull request Jan 9, 2025
Merged
@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2025

/cc @lentzi90 @dtantsur

@tuminoid
Copy link
Member Author

tuminoid commented Jan 9, 2025

/override metal3-ubuntu-e2e-integration-test-main

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@dtantsur
Copy link
Member

dtantsur commented Jan 9, 2025

/lgtm

@metal3-io-bot
Copy link
Collaborator

@dtantsur: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lentzi90
lentzi90 reviewed Jan 9, 2025
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 9, 2025
@tuminoid
Copy link
Member Author

/cc @Sunnatillo

@tuminoid
Copy link
Member Author

/cc @Rozzii

@metal3-io-bot metal3-io-bot requested a review from Rozzii January 13, 2025 08:22
Rozzii
Rozzii reviewed Jan 13, 2025
View reviewed changes
Copy link
Member

@Rozzii Rozzii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 13, 2025
@metal3-io-bot metal3-io-bot merged commit fd3a36e into metal3-io:main Jan 13, 2025
5 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/trigger-shellcheck-in-mariadb branch January 13, 2025 10:39
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key mariadb-image.yaml using file prow/config/jobs/metal3-io/mariadb-image.yaml

In response to this:

Runmariadb script is not a trigger for shellcheck prow job in mariadb-image. Add it.

Another PR is made to mariadb-image to fix the actual shellcheck script.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rozzii Rozzii Rozzii left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@mquhuy mquhuy Awaiting requested review from mquhuy

@dtantsur dtantsur Awaiting requested review from dtantsur

@Sunnatillo Sunnatillo Awaiting requested review from Sunnatillo

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @dtantsur @lentzi90 @Rozzii