Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add CAPM3 release-1.9 to Prow #934

Merged
merged 1 commit into from
Dec 19, 2024
Merged

add CAPM3 release-1.9 to Prow #934

merged 1 commit into from
Dec 19, 2024

Conversation

tuminoid
Copy link
Member

Add CAPM3 release-1.9 to Prow.

Also fix typo in the other CAPM3 release yaml filenames. (provier -> provider)

@metal3-io-bot metal3-io-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 18, 2024
@tuminoid
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main
/hold
Until CAPM3 1.9 exists.

/cc @kashifest @Sunnatillo

@metal3-io-bot metal3-io-bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
/hold
Until CAPM3 1.9 exists.

/cc @kashifest @Sunnatillo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kashifest
kashifest reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@kashifest kashifest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 18, 2024
Sunnatillo
Sunnatillo approved these changes Dec 18, 2024
View reviewed changes
Copy link
Member

@Sunnatillo Sunnatillo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kashifest, Sunnatillo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [Sunnatillo,kashifest]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tuminoid tuminoid mentioned this pull request Dec 19, 2024
Open
48 tasks
@tuminoid
Copy link
Member Author

/unhold

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 19, 2024
@tuminoid
add CAPM3 release-1.9 to Prow
f941d76 
Add CAPM3 release-1.9 to Prow.

Also fix typo in the other CAPM3 release filenames.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid tuminoid force-pushed the tuomo/add-capm3-1.9-to-prow branch from 3f3b5e4 to f941d76 Compare December 19, 2024 12:58
@metal3-io-bot metal3-io-bot removed the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@tuminoid
Copy link
Member Author

New changes are detected. LGTM label has been removed.

Conflict with 1.6 removal due file renames, no other changes.

/override metal3-ubuntu-e2e-integration-test-main

@mquhuy
Copy link
Member

mquhuy commented Dec 19, 2024

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 19, 2024
@metal3-io-bot metal3-io-bot merged commit 8dbd2b3 into metal3-io:main Dec 19, 2024
5 checks passed
@metal3-io-bot metal3-io-bot deleted the tuomo/add-capm3-1.9-to-prow branch December 19, 2024 13:00
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key cluster-api-provier-metal3-release-1.7.yaml using file ``
  • key cluster-api-provider-metal3-release-1.7.yaml using file prow/config/jobs/metal3-io/cluster-api-provider-metal3-release-1.7.yaml
  • key cluster-api-provier-metal3-release-1.8.yaml using file ``
  • key cluster-api-provider-metal3-release-1.8.yaml using file prow/config/jobs/metal3-io/cluster-api-provider-metal3-release-1.8.yaml
  • key cluster-api-provider-metal3-release-1.9.yaml using file prow/config/jobs/metal3-io/cluster-api-provider-metal3-release-1.9.yaml

In response to this:

Add CAPM3 release-1.9 to Prow.

Also fix typo in the other CAPM3 release yaml filenames. (provier -> provider)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kashifest kashifest kashifest left review comments

@Sunnatillo Sunnatillo Sunnatillo approved these changes

@adilGhaffarDev adilGhaffarDev Awaiting requested review from adilGhaffarDev

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tuminoid @metal3-io-bot @mquhuy @Sunnatillo @kashifest