Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IPAM 1.9 release to Prow #931

Merged
merged 1 commit into from
Dec 18, 2024
Merged

add IPAM 1.9 release to Prow #931

merged 1 commit into from
Dec 18, 2024

Conversation

tuminoid
Copy link
Member

Add IPAM 1.9 release to Prow.

@tuminoid
add IPAM 1.9 release to Prow
495c99e 
Add IPAM 1.9 release to Prow.

Signed-off-by: Tuomo Tanskanen <[email protected]>
@tuminoid
Copy link
Member Author

/hold
Needs some JJB first.

@metal3-io-bot metal3-io-bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 17, 2024
@tuminoid
Copy link
Member Author

/override metal3-ubuntu-e2e-integration-test-main
/cc @lentzi90

@metal3-io-bot
Copy link
Collaborator

@tuminoid: Overrode contexts on behalf of tuminoid: metal3-ubuntu-e2e-integration-test-main

In response to this:

/override metal3-ubuntu-e2e-integration-test-main
/cc @lentzi90

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

lentzi90
lentzi90 reviewed Dec 17, 2024
View reviewed changes
Copy link
Member

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@metal3-io-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@metal3-io-bot metal3-io-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 17, 2024
@tuminoid
Copy link
Member Author

/unhold
This also defines basic jobs, and we're merging stuff there now, so this needs to go in, even without e2e being ready.
/cc @kashifest

@metal3-io-bot metal3-io-bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 18, 2024
@tuminoid tuminoid mentioned this pull request Dec 18, 2024
Merged
@adilGhaffarDev
Copy link
Member

/lgtm

@metal3-io-bot metal3-io-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 18, 2024
@metal3-io-bot metal3-io-bot merged commit 4376e3e into metal3-io:main Dec 18, 2024
5 checks passed
@metal3-io-bot
Copy link
Collaborator

@tuminoid: Updated the job-config configmap in namespace prow at cluster default using the following files:

  • key ip-address-manager-release-1.9.yaml using file prow/config/jobs/metal3-io/ip-address-manager-release-1.9.yaml

In response to this:

Add IPAM 1.9 release to Prow.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@metal3-io-bot metal3-io-bot deleted the tuomo/add-ipam-1.9-to-prow branch December 18, 2024 08:09
This was referenced Dec 18, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@kashifest kashifest Awaiting requested review from kashifest

@smoshiur1237 smoshiur1237 Awaiting requested review from smoshiur1237

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tuminoid @metal3-io-bot @adilGhaffarDev @lentzi90