Add class description in v1alpha1 catalog data schema #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Upadhyay <[email protected]>
Signed-off-by: Shubham Upadhyay <[email protected]>
shubham251972
changed the title
leecalcote
reviewed
Jul 20, 2024
Co-authored-by: Lee Calcote <[email protected]> Signed-off-by: Shubham Upadhyay <[email protected]>
leecalcote
requested changes
Jul 20, 2024
| import "embed" | ||
|
|
||
| //go:embed schemas/openapi.yml | ||
| import ( |
There was a problem hiding this comment.
Is this appropriate for the schemas repo or more so for meshkit repo?
Other golang components that use these schemas will import the schemas as packages and have full access to the content of each schema. Is that right?
I'm trying to understand the need for this utility function.
There was a problem hiding this comment.
Yes, this will allow other components to have full access to the content of each schema
|
@shubham251972 will you be taking care of this? #109 |
|
Please see the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #
Signed commits