Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix output problem #3481 #3734

Merged
merged 6 commits into from
Dec 17, 2024

Conversation

de-jcup
Copy link
Member

@de-jcup de-jcup commented Dec 13, 2024

- introduced output helper
- storing now outputs directly to
  file by own helper method
  instead of using core.setOutput(..)
- had problems with axios mock adapter dependency at CI/CD build so changed to npm install
- to provide a fast build the nodes.js modules
  are now cached.
@de-jcup de-jcup force-pushed the feature-3481-handle-github-core-output-problem branch 8 times, most recently from 006ae9b to 85b18ad Compare December 16, 2024 08:37
- directly writing to the file did not work
- directly using set-output command did not work
- using SECHUB_OUTPUT* environment values as alternative
- changed documentation
- wrote tests
@de-jcup de-jcup force-pushed the feature-3481-handle-github-core-output-problem branch from 85b18ad to 40acb9c Compare December 16, 2024 17:42
@de-jcup de-jcup requested a review from sven-dmlr December 16, 2024 18:11
Copy link
Member

@sven-dmlr sven-dmlr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
Found only a typo.
Please also check my comments and decide yourself if you want to change something.
Approved because nothing serious found.

github-actions/scan/deploy.sh Outdated Show resolved Hide resolved
github-actions/scan/README.adoc Show resolved Hide resolved
github-actions/scan/README.adoc Outdated Show resolved Hide resolved
- we have already the github action workflow
  `.github/workflows/release-github-action.yml` which
  automates the deployment process so removed deploy.sh
- added information about deployment workflow inside README.adoc
- updated some documentation part and fixed typo in README.adoc
@de-jcup de-jcup force-pushed the feature-3481-handle-github-core-output-problem branch from 1118ff7 to 1291fb3 Compare December 17, 2024 09:54
@de-jcup de-jcup merged commit 31eb09b into develop Dec 17, 2024
2 of 3 checks passed
@de-jcup de-jcup deleted the feature-3481-handle-github-core-output-problem branch December 17, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants