-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix output problem #3481 #3734
Merged
de-jcup
merged 6 commits into
develop
from
feature-3481-handle-github-core-output-problem
Dec 17, 2024
Merged
Fix output problem #3481 #3734
de-jcup
merged 6 commits into
develop
from
feature-3481-handle-github-core-output-problem
Dec 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- introduced output helper - storing now outputs directly to file by own helper method instead of using core.setOutput(..)
- had problems with axios mock adapter dependency at CI/CD build so changed to npm install - to provide a fast build the nodes.js modules are now cached.
de-jcup
force-pushed
the
feature-3481-handle-github-core-output-problem
branch
8 times, most recently
from
December 16, 2024 08:37
006ae9b
to
85b18ad
Compare
- directly writing to the file did not work - directly using set-output command did not work - using SECHUB_OUTPUT* environment values as alternative - changed documentation - wrote tests
de-jcup
force-pushed
the
feature-3481-handle-github-core-output-problem
branch
from
December 16, 2024 17:42
85b18ad
to
40acb9c
Compare
sven-dmlr
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
Found only a typo.
Please also check my comments and decide yourself if you want to change something.
Approved because nothing serious found.
- we have already the github action workflow `.github/workflows/release-github-action.yml` which automates the deployment process so removed deploy.sh - added information about deployment workflow inside README.adoc - updated some documentation part and fixed typo in README.adoc
de-jcup
force-pushed
the
feature-3481-handle-github-core-output-problem
branch
from
December 17, 2024 09:54
1118ff7
to
1291fb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR