Issue #13: Updated route_failover to treat miss flag to return best on error.

[sergmour]

Updated route_failover to treat miss flag to return best result on error (return miss if there were misses when requesting key from the list of children.
Issue: #13

[dormando]

Thanks! Bonus points if you add a test (it's not too hard to get running).

I probably copied mcrouter's behavior partially. I'll be back at a real computer next week to verify

[dormando]

#4 - oddly this sure sounds like the same report.

[dormando]

ah nm slightly different bug. bad response vs error response

[sergmour]

I'll take a look on Monday and will add a test.

[dormando]

@sergmour any thoughts on tests? I'd like to get this fix in!

[sergmour]

@dormando : Hey Dormando, I've just added a couple of tests. Sorry for the delay, the tests' setup was not straightforward for a person not familiar with lua. Note that the first test will fail for the older routelib.lua but will succeed for the updated one. If you agree with changes for route_failover, do you want me to extend this to the route_zfailover ?

[dormando]

if res:hit() then
  return res
elseif res:ok()  then
  if miss == true then
    rmiss = res
  else
    return res
  end
else
  rerr = res
end

if rmiss then
  return rmiss
else
  return rerr
end

debating if this is more clear or not? I think it's also fewer branches?

thoughts?

[dormando]

thanks for the tests! Just one comment to see if we can simplify that big if or or or at the end

[dormando]

also sorry for the trouble getting the tests going. I'd thought I left directions but probably not.