boot: Change boot_enc_load to take slot number instead of image #2004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In all cases where boot_enc_load is called it is known what slot is addressed, so it is better to just pass the slot number instead of making the boot_enc_load figure out slot number from image index and provided flash area object. Signed-off-by: Dominik Ermel <[email protected]>
|
|
3 tasks
nvlsianpu
reviewed
Jul 24, 2024
| @@ -36,7 +36,7 @@ boot_image_validate_encrypted(const struct flash_area *fa_p, | |||
| memset(&boot_data, 0, sizeof(struct boot_loader_state)); | |||
| image_index = BOOT_CURR_IMG(state); | |||
| if(IS_ENCRYPTED(hdr)) { | |||
| rc = boot_enc_load(BOOT_CURR_ENC(state), image_index, hdr, fa_p, bs); | |||
| rc = boot_enc_load(BOOT_CURR_ENC(state), 1, hdr, fa_p, bs); | |||
There was a problem hiding this comment.
Note for me: I have to check whether this line is fine
nvlsianpu
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In all cases where boot_enc_load is called it is known what slot is addressed, so it is better to just pass the slot number instead of making the boot_enc_load figure out slot number from image index and provided flash area object.