fix small errors

mcosovic · Jan 24, 2022 · 6c8d2e4 · 6c8d2e4
1 parent 1692ca9
commit 6c8d2e4
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "FactorGraph"
 uuid = "528f6532-2a0d-4856-bb42-8bcefd89a10f"
 authors = ["Mirsad Cosovic <[email protected]>"]
-version = "0.1.2"
+version = "0.1.3"
 
 [deps]
 Distributed = "8ba89e20-285c-5b6f-9357-94700520ee1b"

diff --git a/src/utility.jl b/src/utility.jl
@@ -28,7 +28,7 @@ function errorMetric(gbp::Union{ContinuousModel, ContinuousTreeModel})
     @inbounds for i = 1:length(gbp.system.observation)
         rmse += (gbp.system.observation[i] - observationGBP[i])^2
         mae += abs(gbp.system.observation[i] - observationGBP[i])
-        wrss += (gbp.system.observation[i] - observationGBP[i]) / gbp.system.variance[i]
+        wrss += (gbp.system.observation[i] - observationGBP[i])^2 / gbp.system.variance[i]
     end
     rmse = (rmse / NactiveRows)^(1/2)
     mae = mae / NactiveRows
@@ -45,7 +45,7 @@ end
     @inbounds for i = 1:length(gbp.system.observation)
         rmse += (gbp.system.observation[i] - observationGBP[i])^2
         mae += abs(gbp.system.observation[i] - observationGBP[i])
-        wrss += (gbp.system.observation[i] - observationGBP[i]) / gbp.system.variance[i]
+        wrss += (gbp.system.observation[i] - observationGBP[i])^2 / gbp.system.variance[i]
     end
     rmse = (rmse / NactiveRows)^(1/2)
     mae = mae / NactiveRows
@@ -76,7 +76,7 @@ function wls(gbp::Union{ContinuousModel, ContinuousTreeModel})
     @inbounds for i = 1:length(gbp.system.observation)
         rmse += (gbp.system.observation[i] - observationWLS[i])^2
         mae += abs(gbp.system.observation[i] - observationWLS[i])
-        wrss += (gbp.system.observation[i] - observationWLS[i]) / gbp.system.variance[i]
+        wrss += (gbp.system.observation[i] - observationWLS[i])^2 / gbp.system.variance[i]
     end
     rmse = (rmse / NactiveRows)^(1/2)
     mae = mae / NactiveRows