Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hides the GA4 Tag when trying to create a new tag, #PG-3996 #967

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

AltamashShaikh
Copy link
Contributor

Description:

Hides the GA4 Tag when trying to create a new tag,
Fixes: #PG-3996

Review

Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution which allows existing tags to continue working 👍

I left one optional comment. Aside from that, the only thing that we might want to change is the GA4 Event tag description which references the GA4 tag:
image

vue/src/Tag/TagEdit.vue Outdated Show resolved Hide resolved
@AltamashShaikh AltamashShaikh requested a review from snake14 January 6, 2025 02:12
Copy link
Contributor

@snake14 snake14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making the suggested changes. Everything looks good in code and functional testing 👍

@AltamashShaikh AltamashShaikh merged commit 9d9ebba into 5.x-dev Jan 6, 2025
5 checks passed
@AltamashShaikh AltamashShaikh deleted the PG-3996-hide-GA4-tag branch January 6, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants