Added learn more link to copy dialog #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snake14
commented
Nov 28, 2024
There was a problem hiding this comment.
I noticed that the FAQ link in this file wasn't using the function to add the campaign parameters, so I went ahead and fixed it.
snake14
commented
Nov 28, 2024
| a { | ||
| color: @theme-color-link; | ||
| } | ||
| } |
There was a problem hiding this comment.
I had to do this to force the link to be the usual blue since the modal's CSS was overriding that for some reason.
AltamashShaikh
approved these changes
Nov 29, 2024
There was a problem hiding this comment.
@snake14 Are the FAQs in draft state ? All the links were 404, rest worked as expected
@AltamashShaikh Yes. I mentioned that in the PR description, but should have made that note more obvious. |
|
@snake14 Good to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Added learn more link to copy dialog. Container, tag, trigger, and variable each link to their respective FAQ. The FAQs haven't been published yet, so they result in 404 responses when clicked.
Review