Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in-flight frame update #3122

Merged
merged 8 commits into from
Jan 9, 2025

Conversation

adrian-cojocaru
Copy link
Collaborator

Select and update the correct frame uniform/vertex buffers. Currently the same set of buffers were being used (each frame) generating race conditions after the GPU submission.

Fixes #3084, #3085 and should address similar issues (#3116, #2787 (comment))

Copy link

github-actions bot commented Jan 7, 2025

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3122-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +31% +36.1Mi  +438% +26.2Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3122-compared-to-legacy.txt

Copy link

github-actions bot commented Jan 7, 2025

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0062         -0.0062             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3122-compared-to-main.txt

Copy link

github-actions bot commented Jan 7, 2025

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3122-compared-to-main.txt

@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review January 8, 2025 21:31
@louwers
Copy link
Collaborator

louwers commented Jan 9, 2025

!benchmark android

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty sure there is some kind of performance regression.

Still benchmarking locally.

Copy link
Collaborator

@louwers louwers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My bad, was using a wrong (debug) build...

@louwers louwers self-requested a review January 9, 2025 21:03
@louwers louwers enabled auto-merge (squash) January 9, 2025 21:04
@louwers louwers merged commit c1f76cf into maplibre:main Jan 9, 2025
50 checks passed
@adrian-cojocaru adrian-cojocaru linked an issue Jan 9, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Vector elements floating Labels jittery on some styles
3 participants