Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on unsupported attribute type conversion #3066

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

TimSylvester
Copy link
Collaborator

Check matched attribute before trying to clear its dirty flag, preventing a crash when there is no match.

Remove assertion to avoid killing debug builds while attempting to set up the attribute.

Resolves #3042

@TimSylvester TimSylvester added bug Something isn't working OpenGL Issues related to the OpenGL renderer backend labels Dec 4, 2024
@TimSylvester TimSylvester self-assigned this Dec 4, 2024
@louwers
Copy link
Collaborator

louwers commented Dec 4, 2024

Thank you for looking into this and fixing it.

I created an issue to make regression test (I assigned myself, but if you want you can also add it to this PR). #3067

Copy link

github-actions bot commented Dec 4, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3066-compared-to-main.txt

Copy link

github-actions bot commented Dec 4, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  +0.0%    +768  +0.0%    +448    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3066-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.6Mi  +432% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3066-compared-to-legacy.txt

Copy link

github-actions bot commented Dec 4, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0017         +0.0017             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3066-compared-to-main.txt

@louwers louwers merged commit 112edb6 into maplibre:main Dec 4, 2024
50 checks passed
@louwers louwers deleted the bug/3042 branch December 4, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working OpenGL Issues related to the OpenGL renderer backend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

It should not crash on style which works with maplibre 10.2.0
2 participants