Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix instrumentation tests, attempt 2 #3014

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Fix instrumentation tests, attempt 2 #3014

merged 1 commit into from
Nov 13, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Nov 13, 2024

Follow-up to #3012

It printed

Error: Invalid format 'Run PASSED'

So it seems to work now, but I make sure I log to stderr, not stdout.

Also the AWS credential duration need to be extended.

@louwers louwers requested a review from HarelM November 13, 2024 00:50
@louwers louwers added the github_actions Pull requests that update GitHub Actions code label Nov 13, 2024
@louwers louwers self-assigned this Nov 13, 2024
@louwers louwers enabled auto-merge (squash) November 13, 2024 00:58
@github-actions GitHub Actions
Copy link

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3014-compared-to-main.txt

@louwers louwers merged commit d702d18 into maplibre:main Nov 13, 2024
31 of 38 checks passed
@louwers louwers deleted the device-test-fix branch November 13, 2024 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcristici alexcristici alexcristici approved these changes

@HarelM HarelM Awaiting requested review from HarelM

Assignees

@louwers louwers

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@louwers @alexcristici