Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reuse allocated descriptor sets #3002

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

adrian-cojocaru
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Nov 8, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-3002-compared-to-main.txt

Copy link

github-actions bot commented Nov 8, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0076         +0.0073             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-3002-compared-to-main.txt

Copy link

github-actions bot commented Nov 8, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3002-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +30% +34.5Mi  +432% +25.8Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-3002-compared-to-legacy.txt

@adrian-cojocaru adrian-cojocaru marked this pull request as ready for review November 11, 2024 19:26
@louwers louwers enabled auto-merge (squash) November 12, 2024 18:06
@louwers louwers merged commit b303970 into maplibre:main Nov 12, 2024
39 of 42 checks passed
@adrian-cojocaru adrian-cojocaru deleted the descriptor-pool-tweaks branch November 19, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants