Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional sprite to sprite loader test #2974

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Oct 26, 2024

Add another sprite to the sprite loader unit test.

I think parsing this sprite fails on Android right now (#2973). Was an encoding issue, but it would still be good to include another sprite as a test case.

Versatiles style is available under CC-0: https://tiles.versatiles.org/assets/styles/colorful.json

@louwers louwers self-assigned this Oct 26, 2024
Copy link

github-actions bot commented Oct 26, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2974-compared-to-main.txt

Copy link

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  [ = ]       0  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2974-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +28% +32.4Mi  +426% +25.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2974-compared-to-legacy.txt

Copy link

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            +0.0084         +0.0083             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2974-compared-to-main.txt

@louwers louwers requested a review from cgalvan October 27, 2024 13:39
@louwers louwers enabled auto-merge (squash) October 28, 2024 14:03
@louwers louwers merged commit ab00edf into maplibre:main Oct 28, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

2 participants