Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply more clang-tidy fixes #2763

Merged
merged 43 commits into from
Oct 27, 2024
Merged

Apply more clang-tidy fixes #2763

merged 43 commits into from
Oct 27, 2024

Conversation

louwers
Copy link
Collaborator

@louwers louwers commented Aug 24, 2024

No description provided.

Copy link

github-actions bot commented Aug 24, 2024

Bloaty Results (iOS) 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%    -136  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results-ios/pr-2763-compared-to-main.txt

Copy link

github-actions bot commented Aug 24, 2024

Bloaty Results 🐋

Compared to main

    FILE SIZE        VM SIZE    
 --------------  -------------- 
  -0.0%    -400  [ = ]       0    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2763-compared-to-main.txt

Compared to d387090 (legacy)

    FILE SIZE        VM SIZE    
 --------------  -------------- 
   +28% +32.4Mi  +426% +25.4Mi    TOTAL

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/bloaty-results/pr-2763-compared-to-legacy.txt

Copy link

github-actions bot commented Aug 24, 2024

Benchmark Results ⚡

Benchmark                                                     Time             CPU      Time Old      Time New       CPU Old       CPU New
------------------------------------------------------------------------------------------------------------------------------------------
OVERALL_GEOMEAN                                            -0.0150         -0.0151             0             0             0             0

Full report: https://maplibre-native.s3.eu-central-1.amazonaws.com/benchmark-results/pr-2763-compared-to-main.txt

@louwers louwers changed the title More clang-tidy fixes Apply more clang-tidy fixes Oct 27, 2024
@louwers louwers marked this pull request as ready for review October 27, 2024 12:27
@louwers louwers enabled auto-merge (squash) October 27, 2024 12:28
@louwers louwers merged commit 90a798b into maplibre:main Oct 27, 2024
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants