Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node release based on maplibre-js release workflow #1986

Closed
wants to merge 15 commits into from
Closed

Update node release based on maplibre-js release workflow #1986

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
742122a
fix: set fallback-to-build=false
acalcutt Dec 30, 2023
edc9872
fix: Use PR based version release
acalcutt Dec 30, 2023
3346035
remove extra needs: bump_version
acalcutt Dec 30, 2023
a10a35c
remove ref from checkout
acalcutt Dec 30, 2023
4684327
[node][opengl-2] Update workflow for node 21 + allow publish from ope…
acalcutt Dec 9, 2023
b3c452b
updated commented runs-on
acalcutt Dec 31, 2023
6eeec99
make sure semver is installed
acalcutt Dec 31, 2023
205cd5a
add suggested changes
acalcutt Jan 1, 2024
9bf806f
add suggested changes
acalcutt Jan 2, 2024
64607a8
Check if version is published instead of latest
acalcutt Jan 2, 2024
e96cfe3
remove quotes that break version check
acalcutt Jan 2, 2024
192232e
reformat isPublished
acalcutt Jan 2, 2024
7771a74
Update "$GITHUB_OUTPUT"
acalcutt Jan 2, 2024
09fa4b7
change publish os
acalcutt Jan 2, 2024
6e5b533
try to fix last pre-commit error
acalcutt Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
259 changes: 0 additions & 259 deletions .github/workflows/node-ci-mac.yml
View file
Open in desktop

This file was deleted.

13 changes: 9 additions & 4 deletions .github/workflows/node-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,12 @@ jobs:
arch: x86_64
- runs-on: [self-hosted, linux, ARM64]
arch: arm64
# Disabled until Metal backend is complete
# A release for macOS can be made from the opengl-2 branch
# - runs-on: macos-12
# arch: x86_64
# - runs-on: [self-hosted, macOS, ARM64]
# arch: arm64
- runs-on: windows-2022
arch: x86_64
continue-on-error: true
Expand Down Expand Up @@ -134,10 +140,10 @@ jobs:
libwebp-dev
/usr/sbin/update-ccache-symlinks

- name: Setup node
- name: Use Node.js from nvmrc
uses: actions/setup-node@v4
with:
node-version: 20
node-version-file: '.nvmrc'

- name: npm ci
run: npm ci --ignore-scripts
Expand All @@ -155,7 +161,7 @@ jobs:
"PATH=$env:PATH" | Out-File -FilePath $env:GITHUB_ENV -Append

- name: Setup cmake (Linux)
if: runner.os == 'Linux' && runner.arch != 'arm64'
if: runner.os == 'Linux' && matrix.arch != 'arm64'
uses: jwlawson/[email protected]
with:
cmake-version: "3.19.x"
Expand Down Expand Up @@ -278,6 +284,5 @@ jobs:

# On PRs make sure that the npm package can be packaged.
- name: Pack
if: github.ref != 'refs/heads/main'
run: |
npm pack --dry-run
Loading