New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with map field stringifying #43

Open

andrewosh wants to merge 1 commit into mafintosh:master from andrewosh:map-stringify-fix

andrewosh commented Jul 25, 2018 •

edited

Loading

Map fields are currently stringified with an extra map token, which is invalid syntax, i.e.:

message Data {
  map<string, string> something = 1;
}

When parsed + stringified produces:

message Data {
  map<string, string> map something = 1;
}

This PR fixes stringify for map fields, and includes a test that fails on master.


          Fixed bug with map field stringifying

51cbc4d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet