Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed: instrumentation #203

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fixed: instrumentation #203

merged 1 commit into from
Jan 7, 2025

Conversation

heemankv
Copy link
Contributor

@heemankv heemankv commented Jan 7, 2025 •
edited
Loading

The previous fix did not work for process_job because job that was being sent was not updated with the external_id received, we could fetch it again, but doing a DB operation for metrics is a heavy call, hence here we are sending individual components with their most updated values.

@heemankv heemankv self-assigned this Jan 7, 2025
@coveralls
Copy link

Coverage Status

coverage: 67.531% (+0.04%) from 67.496%
when pulling 3bae0a5 on fix/instrument
into cb8d82f on main.

@heemankv heemankv requested review from Mohiiit and ocdbytes January 7, 2025 14:04
ocdbytes
ocdbytes approved these changes Jan 7, 2025
View reviewed changes
Copy link
Member

@ocdbytes ocdbytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm !!!

@heemankv heemankv merged commit 3ec2873 into main Jan 7, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocdbytes ocdbytes ocdbytes approved these changes

@Mohiiit Mohiiit Mohiiit approved these changes

Assignees

@heemankv heemankv

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@heemankv @coveralls @Mohiiit @ocdbytes