forked from ruby-rice/rice
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update from upstream #1
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discussion of support of EOL'd Ruby 2.5
YAML turns 3.0 into 3, which then GitHub Actions picks up as "latest 3.x", when I really want "3.0" explicitly. So we need to quote the number to work around this bug. Rice crashes on 3.1.
Fixed crash in tests with Ruby 3.1
Added missing include
Fix for std::bad_alloc in MethodInfo
Added Ruby 3.2 to CI
And it's only failing on Ruby 3.2 which makes me think that there's a bug in Ruby itself somewhere but I don't know how to track this down.
…e single header file at rice/include/rice/rice.hpp)
…data_type. Note that Object defines a rb_type method which does a very different thing, it calls Ruby's rb_type method.
…, std::map size is defined on an ancestor class _Tree. Currently Rice blows up if it calls size because _Tree is not in the TypeRegistry and thus not bound. Fixes #178.
…ethod_traits to separate files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.