Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix compare price decimal #2053

Merged
merged 4 commits into from
Jan 17, 2025
Merged

fix compare price decimal #2053

merged 4 commits into from
Jan 17, 2025

Conversation

wychoong
Copy link
Contributor

@wychoong wychoong commented Jan 2, 2025

No description provided.

Copy link

vercel bot commented Jan 2, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
lunar-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2025 9:29am

@alecritson
Copy link
Collaborator

Thanks @wychoong Can you provide either a test case or instructions on how to reproduce the issue this is fixing? thanks.

@wychoong
Copy link
Contributor Author

wychoong commented Jan 6, 2025

Thanks @wychoong Can you provide either a test case or instructions on how to reproduce the issue this is fixing? thanks.

Before fix, when saving value, eg: 1000, it will display as 10.00 after refresh, as it will save as it is but display divide by factor. It should have same handling as price field

@alecritson alecritson merged commit 2d0ac1c into lunarphp:1.x Jan 17, 2025
22 checks passed
@wychoong wychoong deleted the patch-1 branch January 17, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants