Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Push Own Leaderboard Entry to the Top #218

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

GODrums
Copy link
Collaborator

@GODrums GODrums commented Jan 4, 2025

Motivation

We want to make it as easy as possible for users to find themselves in the leaderboard.

Description

This PR adds a new entry on top of the leaderboard representing the loggedIn-user. If the user does not appear in the leaderboard yet, it provides a default replacement entry with a rank of #entries + 1.

Testing Instructions

  • run application-server and webapp
  • login with Github and go to the homepage
  • check out different leaderboards to see if your entry is on top of the leaderboard and displays correct data

Screenshots (if applicable)

image

Checklist

General

  • PR title is clear and descriptive
  • PR description explains the purpose and changes
  • Code follows project coding standards
  • Self-review of the code has been done
  • Changes have been tested locally
  • Screenshots have been attached (if applicable)
  • Documentation has been updated (if applicable)

Client (if applicable)

  • UI changes look good on all screen sizes and browsers
  • No console errors or warnings
  • User experience and accessibility have been tested
  • Added Storybook stories for new components
  • Components follow design system guidelines (if applicable)

@GODrums GODrums requested review from milesha and iam-flo January 4, 2025 21:23
@GODrums GODrums self-assigned this Jan 4, 2025
@github-actions github-actions bot added client feature size:M This PR changes 30-99 lines, ignoring generated files. labels Jan 4, 2025
Copy link
Contributor

@milesha milesha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for the improvements 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client feature size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants